mirror of
https://github.com/RIOT-OS/RIOT.git
synced 2024-12-29 04:50:03 +01:00
0607806caa
19263: cpu/stm32/periph/timer: don't stop counter r=maribu a=Enoch247
### Contribution description
From the git comment msg:
If a timer's channel was set with a really small realtive duration from now, such that it would be missed (underflowed), the driver would stop the timer, potentially causing missed ticks. It was stopped to ensure that the channel's output-compare register could be set to the current counter value, before re-enabling the timer's counter. This is a condition that will ensure that the underflow won't happen again and the interrupt will fire, at the cost of losing some ticks for very high speed clocks.
This patch replaces the logic that stopped the timer. Instead it uses a register provided by the timer hardware to trigger timer interrupts via software.
### Testing procedure
1. do
``` bash
$ cd tests/periph_timer_short_relative_set
$ make BOARD=nucleo-f303ze flash term
```
1. follow prompts to run test
1. observe all tests pass
1. apply patch below to break test
1. rerun test
1. observe test fails, so new method is doing its job
##### patch to intentionally break test
```` diff
diff --git a/cpu/stm32/periph/timer.c b/cpu/stm32/periph/timer.c
index 64a6f3a656..7078c46ab4 100644
--- a/cpu/stm32/periph/timer.c
+++ b/cpu/stm32/periph/timer.c
`@@` -177,7 +177,7 `@@` int timer_set(tim_t tim, int channel, unsigned int timeout)
if (value > timeout) {
/* time till timeout is larger than requested --> timer already expired
* ==> let's make sure we have an IRQ pending :) */
- dev(tim)->EGR |= (TIM_EGR_CC1G << channel);
+ //dev(tim)->EGR |= (TIM_EGR_CC1G << channel);
}
````
### Issues/PRs references
- none known
Co-authored-by: Joshua DeWeese <jdeweese@primecontrols.com>
|
||
|---|---|---|
| .. | ||
| arm7_common | ||
| atmega32u4 | ||
| atmega128rfa1 | ||
| atmega256rfr2 | ||
| atmega328p | ||
| atmega1281 | ||
| atmega1284p | ||
| atmega2560 | ||
| atmega_common | ||
| atxmega | ||
| avr8_common | ||
| cc26x0_cc13x0 | ||
| cc26x2_cc13x2 | ||
| cc26xx_cc13xx | ||
| cc2538 | ||
| cortexm_common | ||
| efm32 | ||
| esp32 | ||
| esp8266 | ||
| esp_common | ||
| fe310 | ||
| gd32v | ||
| kinetis | ||
| lm4f120 | ||
| lpc23xx | ||
| lpc1768 | ||
| msp430_common | ||
| msp430fxyz | ||
| native | ||
| nrf5x_common | ||
| nrf51 | ||
| nrf52 | ||
| nrf9160 | ||
| qn908x | ||
| riscv_common | ||
| rpx0xx | ||
| sam0_common | ||
| sam3 | ||
| sam_common | ||
| samd5x | ||
| samd21 | ||
| saml1x | ||
| saml21 | ||
| stellaris_common | ||
| stm32 | ||
| doc.txt | ||
| Kconfig | ||