Cenk Gündoğan
6065be76e1
ndp: warn gcc-7 about intentional fall-through
...
Since gcc-7 `Wimplicit-fallthrough` is activated by using `-Wextra`.
This leads to the following problem when compiling `gnrc_networking`:
```
RIOT/sys/net/gnrc/network_layer/ndp/internal/gnrc_ndp_internal.c: In function ‘gnrc_ndp_internal_set_state’:
RIOT/sys/net/gnrc/network_layer/ndp/internal/gnrc_ndp_internal.c:106:15: error: this statement may fall through [-Werror=implicit-fallthrough=]
t = ipv6_iface->reach_time;
~~^~~~~~~~~~~~~~~~~~~~~~~~
RIOT/sys/net/gnrc/network_layer/ndp/internal/gnrc_ndp_internal.c:109:9: note: here
case GNRC_IPV6_NC_STATE_DELAY:
^~~~
```
The fall-through in this code is intentional. There are several ways to
warn the comiler about such intentional fall-throughs, which include
e.g. attributed empty statements (`__attribute__ ((fallthrough));`).
I don't like tis approach however. The best way would probably be to
remove this fall-through from the code. However, to keep the diff
minimal, and since ndp will change in the future, I went for warning
the compiler using comments.
The compiler checks comments for several *fall through* regexs to
decide whether a fallthrough was intentional or not.
You can read more about this gcc option in [1]. A note about
fallthrough comment regexs is at the bottom of this article.
[1] https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/
2017-05-30 14:23:37 +02:00
Martine Lenders
9a16dab681
Merge pull request #7106 from BytesGalore/adjust_edbg_commit_hash
...
dist/edbg: forward commit hash to added samr21-xpro (rev D)
2017-05-30 10:18:07 +02:00
BytesGalore
eac2b0c761
dist/edbg: forward commit hash to added samr21-xpro (rev D)
2017-05-30 08:59:11 +02:00
Joakim Nohlgård
f6073c0aa4
Merge pull request #6993 from gebart/pr/kinetis-isr
...
kinetis: Unify default ISR definitions
2017-05-30 08:48:50 +02:00
Martine Lenders
19d485d1b1
Merge pull request #7102 from haukepetersen/opt_gcoap_const
...
net/gcoap: make input parameters const
2017-05-29 11:57:28 +02:00
Hauke Petersen
bb90e293a2
net/gcoap: make input parameters const
2017-05-26 16:34:40 +02:00
3b7252c7de
Merge pull request #7099 from miri64/doc/fix/application
...
doc: fix "Creating an application" page
2017-05-24 18:40:28 +02:00
Martine Lenders
cac6da3fb7
doc: fix "Creating an application" page
2017-05-24 18:23:30 +02:00
Martine Lenders
d4693648ba
Merge pull request #7095 from kaspar030/add_headerguard_check_script
...
dist: tools: add headerguard check script
2017-05-24 18:08:29 +02:00
Vincent Dupont
ee7a776a9f
Merge pull request #7059 from OTAkeys/pr/fix_ls_handler
...
sc_vfs: fix _ls_handler
2017-05-24 17:55:52 +02:00
60fb6d2d50
dist: tools: changed_files.sh: add msba2 tools to exclude list
2017-05-24 17:54:02 +02:00
0fcc7d3834
cleanup: apply headerguard script output
2017-05-24 17:54:02 +02:00
a65931c04a
add some missing header guards
2017-05-24 17:54:01 +02:00
ed31db4702
dist: tools: build_and_test.sh: add header guard check
2017-05-24 17:54:01 +02:00
de07fe07e5
dist: tools: headerguard: initial commit
2017-05-24 17:54:01 +02:00
Hauke Petersen
c57d67fab8
Merge pull request #7073 from kaspar030/add_edbg_support
...
tools: add edbg support
2017-05-24 17:35:42 +02:00
Hauke Petersen
71ff62011b
Merge pull request #7098 from haukepetersen/add_kinetis_uartmodeconf
...
cpu/kinetis: make UART mode configurable per board
2017-05-24 15:58:32 +02:00
8060c48427
boards: samd21-xpro: enable use of edbg
2017-05-24 14:52:45 +02:00
f2cc58e8ed
boards: samr21-xpro: enable use of edbg
2017-05-24 14:52:45 +02:00
d7d796b80d
makefiles: add edbg tool support
2017-05-24 14:52:44 +02:00
6a9175944c
dist: tools: add edbg
2017-05-24 14:52:44 +02:00
Hauke Petersen
867b09c224
cpu/kinetis: make UART mode configurable per board
2017-05-24 14:48:49 +02:00
Vincent Dupont
151c469d9e
sc_vfs: fix _ls_handler
...
Calls to vfs_closedir were missing at the end of _ls_handler causing umount
ro return an error.
2017-05-24 12:10:52 +02:00
Hauke Petersen
7a1fcdf0b8
Merge pull request #6469 from kb2ma/gcoap/observe
...
gcoap: Observe extension server
2017-05-24 09:11:15 +02:00
Ken Bannister
3abff6d140
gcoap: Update example for Observe, including documentation.
2017-05-23 17:55:04 -04:00
Ken Bannister
9d37be2729
gcoap: Add server-side Observe registration and notifications.
2017-05-23 17:55:04 -04:00
Ken Bannister
05fe8527a2
nanocoap: Update pkg for Observe commits.
2017-05-23 17:47:39 -04:00
Martine Lenders
18bad155ad
Merge pull request #7074 from haukepetersen/fix_borderrouter_maketargets
...
examples/gnrc_border_router: remove `make term` warnings
2017-05-23 15:06:32 +02:00
Hauke Petersen
92076cdf50
example/gnrc_border_router: use TERMDEPS
2017-05-23 14:25:11 +02:00
Hauke Petersen
2739354bab
make/serial.inc.mk: set TERMFLAGS only if not set
2017-05-23 14:25:11 +02:00
Hauke Petersen
3098a277ed
Makefile.include: add optional TERMDEPS to make term
2017-05-23 14:25:11 +02:00
a3907c99d5
Merge pull request #7079 from haukepetersen/opt_guard_unusedmoduleheaders
...
sys/drivers: guard l2filter.h, netstats.h includes
2017-05-23 13:46:22 +02:00
Hauke Petersen
d488fdc1e3
sys/drivers: guard l2filter.h, netstats.h includes
2017-05-23 13:39:49 +02:00
8d3b7a28fc
makefiles: openocd.inc.mk: make FLASHER overridable
2017-05-23 10:17:18 +02:00
BytesGalore
2ef5cff688
Merge pull request #6072 from MichelRottleuthner/fatfs_testing
...
package: add generic FatFs
2017-05-23 09:03:19 +02:00
0b918db35c
Merge pull request #7068 from haukepetersen/add_tool_bossa
...
tools: introduce shared tooling for using BOSSA
2017-05-23 07:17:13 +02:00
c53e9271ba
dist: tools: bossa: add makefile rule to clean generated binary
2017-05-22 16:18:07 +02:00
Martine Lenders
0ec8593a71
Merge pull request #7089 from haukepetersen/fix_gcoap_minormisc
...
net/gcaop: misc. minor style fixes and optimizations
2017-05-22 15:16:50 +02:00
Francisco Acosta
ea27e96e7e
Merge pull request #7071 from kYc0o/gcoap_add_dependencies
...
gcoap: move dependencies to actual module
2017-05-22 14:21:07 +02:00
Sebastian Meiling
4463b2655c
Merge pull request #7088 from kaspar030/fix_xtimer_periodic_wakeup_name
...
tests: xtimer_periodic_wakeup: fix test application name
2017-05-22 14:16:16 +02:00
Hauke Petersen
09119708e9
net/gcoap: fixed/unified alignment in gcoap header
2017-05-22 13:55:20 +02:00
Hauke Petersen
ba5635889c
net/gcoap: make gcoap_op_state return count directly
2017-05-22 13:50:59 +02:00
ad027e0498
tests: xtimer_periodic_wakeup: fix test application name
2017-05-22 13:49:30 +02:00
Hauke Petersen
cd4109100f
net/gcoap: fixed coding style issue
2017-05-22 13:47:36 +02:00
Hauke Petersen
459f6083e9
net/gcoap: fixed typo in header doxygen
2017-05-22 13:47:20 +02:00
0d98a91e18
Merge pull request #7080 from kaspar030/deduplicate_sam0_board_makefiles
...
boards: sam0: deduplicate sam0 board makefiles
2017-05-22 13:10:49 +02:00
kYc0o
bc2387ed25
tests-gcoap: move dependencies to gcoap module
2017-05-22 12:23:43 +02:00
kYc0o
a320b9458b
examples/gcoap: remove non-necessary dependencies
2017-05-22 12:23:43 +02:00
kYc0o
db3a5453a4
Makefile.dep: add dependencies for gcoap
2017-05-22 12:23:43 +02:00
Francisco Acosta
6aad87f6bd
Merge pull request #7078 from haukepetersen/fix_boards_serialincmk
...
boards: make use of `serial.inc.mk`
2017-05-22 12:00:32 +02:00
