1
0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2024-12-29 04:50:03 +01:00
RIOT/pkg/tlsf
Juan Carrano cc907fa54e pkg/tlsf: Fix the way system functions are overriden.
The correct way to overrride the malloc family of functions in newlib-nano is
to provide the *_r (reentrant) variants. Newlib implements the "normal"
functions on top of these (see the newlib source code). Also, internally it calls
the *_r functions when allocating buffers.

If only the "normal" non-reentrant functions are provided this will mean that
some of the code will still use the vanilla newlib allocator. Furthermore, if
one uses the whole heap as a pool for TLSF then the system may in the best case
crash as there is no enough memory for its internall allocations or in the worst
case function eratically (this depends on how the heap reserved, there is an
upcomming series of commits in that direction).

This commit splits the handling between newlib and native. It also prepares the
ground for future work on the pool initialization.

Right now I could only test this in ARM and native and I cannot ensure it will
work on other platforms. Replacing the system's memory allocator is not something
that can be taken lightly and will inevitably require diving into the depths of
the libc. Therefore I would say that using TLSF as a system wide allocator is ATM
supported officially only on those plaftorms.

Testing:

Aside from reading the newlib sources, you can see the issue in a live system
using the debugger.

Compile any example (with or without tlsf-malloc), grab a debugger and place
a breakpoint in sbrk and _sbrk_r. Doing a backtrace will reveal it gets called
by _malloc_r.
2019-09-17 21:18:50 +02:00
..
contrib pkg/tlsf: Fix the way system functions are overriden. 2019-09-17 21:18:50 +02:00
patches pkg/tlsf: Refactor the TLSF package and bring back original TLSF api. 2018-05-18 15:41:07 +02:00
.gitignore pkg: unify git paradigms for packages 2016-01-26 23:22:47 +01:00
doc.txt pkg/tlsf: Refactor the TLSF package and bring back original TLSF api. 2018-05-18 15:41:07 +02:00
Makefile pkg/tlsf: Refactor the TLSF package and bring back original TLSF api. 2018-05-18 15:41:07 +02:00
Makefile.dep pkg/tlsf: Fix the way system functions are overriden. 2019-09-17 21:18:50 +02:00
Makefile.include pkg/tlsf: Fix the way system functions are overriden. 2019-09-17 21:18:50 +02:00
Makefile.tlsf pkg/tlsf: Refactor the TLSF package and bring back original TLSF api. 2018-05-18 15:41:07 +02:00