Lucas Jenss
6998ffbb14
cppcheck: Provide consistent reason formatting for all cppcheck-suppresses
2017-10-10 10:25:20 -07:00
Cenk Gündoğan
6065be76e1
ndp: warn gcc-7 about intentional fall-through
...
Since gcc-7 `Wimplicit-fallthrough` is activated by using `-Wextra`.
This leads to the following problem when compiling `gnrc_networking`:
```
RIOT/sys/net/gnrc/network_layer/ndp/internal/gnrc_ndp_internal.c: In function ‘gnrc_ndp_internal_set_state’:
RIOT/sys/net/gnrc/network_layer/ndp/internal/gnrc_ndp_internal.c:106:15: error: this statement may fall through [-Werror=implicit-fallthrough=]
t = ipv6_iface->reach_time;
~~^~~~~~~~~~~~~~~~~~~~~~~~
RIOT/sys/net/gnrc/network_layer/ndp/internal/gnrc_ndp_internal.c:109:9: note: here
case GNRC_IPV6_NC_STATE_DELAY:
^~~~
```
The fall-through in this code is intentional. There are several ways to
warn the comiler about such intentional fall-throughs, which include
e.g. attributed empty statements (`__attribute__ ((fallthrough));`).
I don't like tis approach however. The best way would probably be to
remove this fall-through from the code. However, to keep the diff
minimal, and since ndp will change in the future, I went for warning
the compiler using comments.
The compiler checks comments for several *fall through* regexs to
decide whether a fallthrough was intentional or not.
You can read more about this gcc option in [1]. A note about
fallthrough comment regexs is at the bottom of this article.
[1] https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/
2017-05-30 14:23:37 +02:00
Oleg Hahm
4f4214235b
timex: unambiguous time conversion macros
2017-01-19 13:18:08 +01:00
DipSwitch
6a484d19cb
ndp: fix debug in message in gnrc_ndp_internal_send_nbr_sol
2016-10-03 11:56:22 +02:00
7718f114cb
all: remove pointer casts for msg.content.ptr
2016-06-02 23:13:42 +02:00
Oleg Hahm
991c71cf27
gnrc ipv6: use ipv6_addr_t ptr for hdr_build
2016-03-23 15:20:12 +01:00
Oleg Hahm
360413a033
gnrc ipv6 hdr: remove len params from hdr_build
2016-03-23 15:20:11 +01:00
Michael Andersen
60f6aeaf70
ndp: change rtr adv src to link local
2016-03-08 21:33:35 -08:00
Martine Lenders
0e32745b8a
gnrc: replace static initializers with constants where sensible
2016-03-01 18:29:15 +01:00
ded39b461e
sys: random: rename genrand_* to random_*
2016-02-29 21:33:17 +01:00
Cenk Gündoğan
d58e1385b2
ndp/internal: fix pio flags for rtr adv
2016-01-28 14:03:19 +01:00
test
8d1f91f128
ndp: check for A flag in received PIO
2016-01-26 14:34:48 +01:00
Martine Lenders
a4a8e83ac7
Merge pull request #4446 from Yonezawa-T2/neighbor_discovery_option_for_6lowpan
...
gnrc_ndp: fixed ND Option handling for 6LoWPAN
2016-01-06 14:03:43 +01:00
Yonezawa-T2
639f7dc020
gnrc_ndp: fixed ND Option handling for 6LoWPAN
...
The forms of the Source/Target Link-layer Address option for 6LoWPAN are defined
in RFC 4944 Section 8:
https://tools.ietf.org/html/rfc4944#section-8
The address is 16 bit if length is 1, 64 bit if length is 2.
2016-01-06 09:38:47 +09:00
Yonezawa-T2
38d3dc725b
gnrc_ndp_internal: add missing unlock when the pktbuf is full
...
Squashed a commit by Cenk Gündoğan <cnkgndgn@gmail.com>.
2015-12-25 11:08:28 +09:00
test
432f6c34ab
ndp: use on-link flag instead of auto flag
2015-11-26 23:37:39 +01:00
Martine Lenders
6595e8c57f
Merge pull request #4174 from authmillenon/gnrc_ndp_internal/fix/send-ras-without-pio
...
gnrc_ndp_internal: send RAs even when there are no PIOs
2015-11-17 14:01:55 +01:00
Cenk Gündoğan
bf3a504691
nc: ndp: sixlowpan: remove timex.h include
2015-11-09 14:55:04 +01:00
Cenk Gündoğan
5aaea3879f
netif: ndp: gnrc_ipv6_netif_t::retrans_timer -> uint32_t
2015-11-09 14:55:04 +01:00
Cenk Gündoğan
b59fc825a3
netif: nc: ndp: gnrc_ipv6_netif_t::reach_time -> uint32_t
2015-11-09 14:55:01 +01:00
Cenk Gündoğan
47fe901187
ndp: timex -> uint32_t for probe delay time
2015-11-09 14:54:42 +01:00
Cenk Gündoğan
47a02d9d07
ipv6: ndp: sixlowpan: remove vtimer includes
2015-11-02 15:02:08 +01:00
Martine Lenders
23f8fecc04
Merge pull request #4157 from cgundogan/pr/nc/xtimer_nbr_sol_timer
...
nc: use xtimer for gnrc_ipv6_nc_t::nbr_sol_timer
2015-10-28 17:51:48 +01:00
Cenk Gündoğan
4297972054
nc: use xtimer for gnrc_ipv6_nc_t::nbr_sol_timer
2015-10-28 15:24:45 +01:00
Oleg Hahm
64a653496a
gnrc: ndp: fix calculation of L2 address length
...
If no source address was provided by layer 2 or someone removed it, the calculation of its length is done using the length field from the Source/Target Link-layer Address option (https://tools.ietf.org/html/rfc4861#section-4.6.1 ). The length is specified as units of 8 octets. Hence, it should be multiplied by 8, not divided.
2015-10-27 20:13:50 +01:00
Martine Lenders
ae567efc9a
gnrc_ndp_internal: send RAs even when there are no PIOs
2015-10-27 19:33:52 +01:00
Cenk Gündoğan
59a8b929f6
nc: use xtimer for gnrc_ipv6_nc_t::nbr_adv_timer
2015-10-26 16:59:16 +01:00
Cenk Gündoğan
609cf7fb12
ndp/internal: use dst instead of tgt to determine the nc_entry
2015-10-26 15:35:47 +01:00
Cenk Gündoğan
e72bde5805
ndp/internal: add assert to test for nc_entry if target is non-unicast
2015-10-26 15:18:58 +01:00
Cenk Gündoğan
0146c1b1b9
netif: use xtimer for gnrc_ipv6_netif_addr_t::valid_timeout
2015-10-20 22:55:12 +02:00
Martine Lenders
891450d29d
gnrc_netapi: recover from message send errors
2015-09-29 16:58:08 +02:00
Martine Lenders
893008f1e2
gnrc_ndp_internal: fix variable scope
2015-09-25 10:53:13 +02:00
Martine Lenders
217f8a26d8
gnrc_ndp_internal: fix coding style
2015-09-25 10:52:51 +02:00
Martine Lenders
39ade25511
gnrc_ndp_internal: prevent non-terminating loop
2015-09-25 10:51:01 +02:00
Martine Lenders
8621407f00
GNRC 6LR: don't include PIOs for other interface's prefixes
2015-09-25 01:11:53 +02:00
Oleg Hahm
c5b1156909
IPv6 nd: missing parameter for debug function
2015-09-24 13:17:21 +02:00
Martine Lenders
1682b76866
gnrc_ndp_internal: adapt nbr_sol send function to get src
2015-09-18 00:23:12 +02:00
Martine Lenders
8f2b2e15d2
Merge pull request #3836 from cgundogan/pr/ndp/rm_dupl_pio
...
ndp: pio - check if prefix has been processed before
2015-09-17 02:40:08 +02:00
Martine Lenders
a19a04c753
Merge pull request #3853 from OlegHahm/6lowpan_nd_router_fixes
...
6lowpan nd router fixes
2015-09-17 01:37:39 +02:00
Oleg Hahm
b15660033a
sixlowpan nd: send actually router advertisements
2015-09-16 23:59:43 +02:00
Oleg Hahm
bf22190434
6lowpan nd: set rtr adv flag on rtr adv reception
...
A 6LoWPAN router should turn into a 6LoWPAN router as soon as it has
been configured by receiving an advertisement itself.
2015-09-16 23:53:47 +02:00
Cenk Gündoğan
92cbc1f254
ndp: pio - check if prefix has been processed before
2015-09-16 22:58:45 +02:00
Cenk Gündoğan
14d899bf83
ndp: assertify pio prefix len check and include 0 and 128
2015-09-12 13:11:01 +02:00
Martine Lenders
e51786910d
gnrc_ndp: add PIO to router advertisements
...
The PIOs for the configured prefixes were generated, but never added to
the packet, causing some problems in the packet buffer.
Fixes #3815 (possibly)
2015-09-11 15:54:57 +02:00
Martine Lenders
2364621eb2
gnrc_ndp: fix setting of addresses by PIO
2015-09-11 11:51:08 +02:00
DipSwitch
d770561616
ndp: fix the NDP PI option length checking
2015-09-10 11:28:36 +02:00
Oleg Hahm
8b16f3ef06
Merge pull request #3749 from authmillenon/gnrc_sixlowpan_nd_router/feat/initial
...
gnrc_sixlowpan_nd_router: initial import of router behavior of 6LoWPAN-ND
2015-09-10 10:49:36 +02:00
Martine Lenders
40912d3d66
gnrc: adapt for gnrc_sixlowpan_nd_router
2015-09-10 02:13:45 +02:00
Oleg Hahm
b4c00d5f6e
gnrc: ndp: fix PIO address validity check
2015-09-10 01:31:32 +02:00
Martine Lenders
84768b1747
Merge pull request #3748 from authmillenon/gnrc_sixlowpan_nd/feat/initial
...
gnrc_sixlowpan_nd: initial import of host behavior of 6LoWPAN-ND
2015-09-09 11:58:01 +02:00
