- add `static` qualifiers where sensible
- drop `volatile` qualifier that was incorrectly used
- add a comment on use of shared memory for inter-thread communication
19999: nib/_nib-6ln: bail out early if address is no longer assigned r=miri64 a=benpicco
Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com>
19990: sys/psa_crypto: allow repeated initialization r=benpicco a=mguetschow
### Contribution description
- simple unit test which calls `psa_crypto_init()` twice
- fix to no re-initialize key slots (which left them in a broken state)
### Testing procedure
- `make -C tests/sys/psa_crypto all test` succeeds
- `git checkout HEAD~1 && make -C tests/sys/psa_crypto all test` fails
Co-authored-by: Mikolai Gütschow <mikolai.guetschow@tu-dresden.de>
20011: tests/unittests: add a unit test for ztimer r=benpicco a=maribu
### Contribution description
This adds test coverage for removing ztimers with focus on ensuring that offsets are correctly updated on subsequent timers (e.g. not having timers fire too early).
### Testing procedure
Run the unit tests (will be done by the CI as well). Maybe also introduce a random bug in `ztimer_remove()` and check if this is indeed caught by the unit tests.
### Issues/PRs references
Prompted by https://github.com/RIOT-OS/RIOT/pull/18977#issuecomment-1764258356
Co-authored-by: Marian Buschsieweke <marian.buschsieweke@posteo.net>
20005: tests/pkg/minmea: adding GGA, GSA and RMC sentences to test application r=benpicco a=jan-mo
This will extend the minmea test with additional NMEA sentences like GGA, GSA and RMC.
20008: release-test.yml: Fix strasbourg spelling r=benpicco a=MrKevinWeiss
### Contribution description
Small typo fix... stasbourg -> strasbourg
### Testing procedure
Really not easy since we need an RC to actually test it (since these tests can only be run on RCs)... but the RC1 doesn't contain the `openmote-b` fixes.
### Issues/PRs references
Co-authored-by: Jan Mohr <jan.mohr@ml-pa.com>
Co-authored-by: MrKevinWeiss <weiss.kevin604@gmail.com>
This adds test coverage for removing ztimers with focus on ensuring that
offsets are correctly updated on subsequent timers (e.g. not having
timers fire too early).
20007: release-test.yml: Add stasbourg creds r=miri64 a=MrKevinWeiss
### Contribution description
This adds creds for stasbourg needed for the `openmote-b` tests in the release specs.
### Testing procedure
Hmmm... I don't know how easy it is. I will try to link results of the workflow from my personal fork maybe?
### Issues/PRs references
Needed for https://github.com/RIOT-OS/Release-Specs/pull/289
Co-authored-by: MrKevinWeiss <weiss.kevin604@gmail.com>
19465: drivers/mtd: use XFA for pointers to defined MTDs r=benpicco a=gschorcht
### Contribution description
This PR provides the support to hold pointers to defined MTDs within a XFA. The XFA allows
- to access MTDs of different types (`mtd_flashpage`, `mtd_sdcard`, `mtd_emulated`, ...) by an index
- to determine the number of MTDs defined in the system.
### Testing procedure
To be defined once PR #19443 is merged because emulated MTDs will allow to test this PR on arbitrary boards.
### Porting Guide
For external boards:
- remove the `MTD_NUMOF` definition from `board.h`
- add `MTD_XFA_ADD(<mtd_dev>, <idx>);` to the definition of `<mtd_dev>`.
- `MTD_0`, `MTD_1`, … defines are no longer needed.
### Issues/PRs references
Related to PR #19443
19981: Fletcher32: Add incremental API r=benpicco a=bergzand
### Contribution description
This PR extends the current fletcher32 checksum with an incremental API mode. This way the bytes to be checksummed can be supplied via multiple successive calls and do not have to be provided in a single consecutive buffer.
I've also rephrased the warning with the original function a bit as that function uses an `unaligned_get_u16` to access the data. The data thus does not require alignment, but the length does need to be supplied as number of 16 bit words.
### Testing procedure
The test has been extended
### Issues/PRs references
None
19995: sys/psa_crypto: Fix macro for public key max size and SE example r=benpicco a=Einhornhool
### Contribution description
#### 1. Wrong public key size when using secure elements, introduced by #19954
Fixed conditions for key size macros in `crypto_sizes.h`.
#### 2. EdDSA and ECDSA examples fail when using a secure element because of unsopported changes introduced by #19954
Updated `example/psa_crypto` to use only supported functions for secure elements.
### Testing procedure
Build `example/psa_crypto` for secure elements and run application
Output on master:
```
2023-10-19 14:33:24,372 # main(): This is RIOT! (Version: 2019.07-devel-22378-gb6772)
2023-10-19 14:33:24,372 # HMAC SHA256 took 56393 us
2023-10-19 14:33:24,372 # Cipher AES 128 took 68826 us
2023-10-19 14:33:24,372 # *** RIOT kernel panic:
2023-10-19 14:33:24,373 # HARD FAULT HANDLER
2023-10-19 14:33:24,373 #
2023-10-19 14:33:24,373 # *** rebooting...
```
Output with fixes:
```
2023-10-19 13:35:24,715 # main(): This is RIOT! (Version: 2019.07-devel-22384-g8ef66-dev/psa-crypto-fixes)
2023-10-19 13:35:24,715 # HMAC SHA256 took 56374 us
2023-10-19 13:35:24,715 # Cipher AES 128 took 68805 us
2023-10-19 13:35:24,715 # ECDSA took 281164 us
2023-10-19 13:35:24,715 # All Done
```
Co-authored-by: Gunar Schorcht <gunar@schorcht.net>
Co-authored-by: Koen Zandberg <koen@bergzand.net>
Co-authored-by: Lena Boeckmann <lena.boeckmann@haw-hamburg.de>
19983: pkg/nanocbor: Update for fixed nanocbor_skip_simple() r=miri64 a=bergzand
### Contribution description
`@miri64` found a bug in NanoCBOR which is fixed with the latest commit.
Important changes:
- Fixed a bug in nanocbor_skip_simple with (b|t)str types
### Testing procedure
The pkg test should still pass.
### Issues/PRs references
None
Co-authored-by: Koen Zandberg <koen@bergzand.net>
19979: dist/testbed-support: Add openmote board r=aabadie a=MrKevinWeiss
### Contribution description
As part of fixing the automated release specs test we will need support for another `cc2538` based board. I was able to get the tests passing with adaption here and to the release specs.
### Testing procedure
### Issues/PRs references
Co-authored-by: MrKevinWeiss <weiss.kevin604@gmail.com>