During RIOT Summit 2018 the attending maintainers found that the
organization for the review process involving multiple maintainers is
lacking both in process description and existing mechanisms.
This changes the "Organisation of reviewing between maintainers"
section of the maintenance guidelines, to be in accordance with the
results of the discussions spawned from this fact.
If approved the following labels are added to GitHub:
- Reviewed: 1-fundamentals
- Reviewed: 2-code-design
- Reviewed: 3-testing
- Reviewed: 4-coding-conventions
- Reviewed: 5-documentation
This release fixed some bugs related to disabling float support in the
parser.
The float support is now optional and can be enabled by including the
tinycbor_float module. This allows for compiling on AVR as that platform
doesn't support the float specific defines used by tinycbor.
gnrc_sock_recv used to duplicate functionality of gnrc_ipv6_get_header,
but additionally checked whether the IPv6 snip is large enough.
All checks are now included in gnrc_ipv6_get_header, but as most of them
stem from programming / user errors, they were moved into asserts; this
constitutes an API change.
This new tool allows configuring the reset pin for nRF52-based
boards. As the reset pin configuration is persistent, it does not
make sense to include it into the board code...
The board should process its CPU features.
This has the consequence to make 'periph_pm' visible to the board.
I also removed the duplicate FEATURES_PROVIDED from the board defined in
the cpu.
Remove duplicate handling of `periph_rtc` dependency to `periph_rtt` now
declared in the cpu.
Also the makefiles should not parse FEATURES_REQUIRED as it does not
guarantee anything as features could also be requested by FEATURES_OPTIONAL.
In practice it should parse it using `USEMODULE`.
It is the role of boards based on 'cpu/fe310' to give the configuration
for the rtc/rtt.
The fe310/periph/rtc implementation depends on having periph/rtt configured
by the board so depends on the board 'providing' the periph_rtt feature
and declaring the required macros.
It should not simply depend of the 'periph_rtt' module as this does not
enforce having a configuration for the module in the board.
In practice, when compiling, it would result in undefined 'RTT' symbols,
instead of the build system detecting it.
