Cenk Gündoğan
6065be76e1
ndp: warn gcc-7 about intentional fall-through
...
Since gcc-7 `Wimplicit-fallthrough` is activated by using `-Wextra`.
This leads to the following problem when compiling `gnrc_networking`:
```
RIOT/sys/net/gnrc/network_layer/ndp/internal/gnrc_ndp_internal.c: In function ‘gnrc_ndp_internal_set_state’:
RIOT/sys/net/gnrc/network_layer/ndp/internal/gnrc_ndp_internal.c:106:15: error: this statement may fall through [-Werror=implicit-fallthrough=]
t = ipv6_iface->reach_time;
~~^~~~~~~~~~~~~~~~~~~~~~~~
RIOT/sys/net/gnrc/network_layer/ndp/internal/gnrc_ndp_internal.c:109:9: note: here
case GNRC_IPV6_NC_STATE_DELAY:
^~~~
```
The fall-through in this code is intentional. There are several ways to
warn the comiler about such intentional fall-throughs, which include
e.g. attributed empty statements (`__attribute__ ((fallthrough));`).
I don't like tis approach however. The best way would probably be to
remove this fall-through from the code. However, to keep the diff
minimal, and since ndp will change in the future, I went for warning
the compiler using comments.
The compiler checks comments for several *fall through* regexs to
decide whether a fallthrough was intentional or not.
You can read more about this gcc option in [1]. A note about
fallthrough comment regexs is at the bottom of this article.
[1] https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/
2017-05-30 14:23:37 +02:00
Oleg Hahm
a9cc8babba
gnrc: ndp: suppress wrong cppcheck warnings
2017-04-14 14:36:15 +02:00
Martine Lenders
2fd69653af
gnrc_ndp: do not add new neighbors as TENTATIVE on 6LR
2017-01-23 14:02:26 +01:00
Oleg Hahm
4f4214235b
timex: unambiguous time conversion macros
2017-01-19 13:18:08 +01:00
DipSwitch
6a484d19cb
ndp: fix debug in message in gnrc_ndp_internal_send_nbr_sol
2016-10-03 11:56:22 +02:00
Martine Lenders
bd230d3b63
gnrc_ipv6: gnrc_icmpv6: use dispatch_receive helper function
2016-08-18 13:25:07 +02:00
7718f114cb
all: remove pointer casts for msg.content.ptr
2016-06-02 23:13:42 +02:00
Cenk Gündoğan
1791ef5581
gnrc_ndp: check nc_entry before using it
2016-05-17 09:52:16 +02:00
Oleg Hahm
028c9d8029
Merge pull request #5139 from authmillenon/gnrc_ndp/fix/unset-isrouter-on-rtr-sol
...
gnrc_ndp: unset isRouter flag for neighbor sending RS
2016-03-28 19:29:33 +02:00
Martine Lenders
802136dd9a
gnrc_ndp: unset isRouter flag for neighbor sending RS
2016-03-28 19:16:51 +02:00
Oleg Hahm
991c71cf27
gnrc ipv6: use ipv6_addr_t ptr for hdr_build
2016-03-23 15:20:12 +01:00
Oleg Hahm
360413a033
gnrc ipv6 hdr: remove len params from hdr_build
2016-03-23 15:20:11 +01:00
Michael Andersen
60f6aeaf70
ndp: change rtr adv src to link local
2016-03-08 21:33:35 -08:00
Michael Andersen
1082a93a42
ndp: fix neighbor advertisement byte ordering
2016-03-05 13:39:50 -08:00
Martine Lenders
0e32745b8a
gnrc: replace static initializers with constants where sensible
2016-03-01 18:29:15 +01:00
ded39b461e
sys: random: rename genrand_* to random_*
2016-02-29 21:33:17 +01:00
Cenk Gündoğan
0ac4ee705c
ipv6: rpl: add source routing header for RPL
2016-02-27 20:39:12 +01:00
Oleg Hahm
fc398d857d
ndp: fix NCE creation on RA reception
...
RFC4861 says: "If a Neighbor Cache entry is created for the router
[while processing route advertisements], its reachability state MUST be
set to STALE as specified in Section 7.3.3."
2016-02-18 19:53:39 +01:00
Martine Lenders
379703ae3a
gnrc: use gnrc_pkt_search_type instead of LL_SEARCH_SCALAR
2016-02-11 01:05:02 +01:00
Cenk Gündoğan
d58e1385b2
ndp/internal: fix pio flags for rtr adv
2016-01-28 14:03:19 +01:00
Cenk Gündoğan
617796241e
Merge pull request #4295 from authmillenon/gnrc_ipv6_nc/enh/l2addr-lookup
...
gnrc_ipv6_nc: introduce L2 address lookup function
2016-01-26 19:30:01 +01:00
test
8d1f91f128
ndp: check for A flag in received PIO
2016-01-26 14:34:48 +01:00
Martine Lenders
0b787b9e02
gnrc_ndp_node: use gnrc_ipv6_nc_get_l2_addr()
2016-01-26 10:19:16 +01:00
Martine Lenders
a4a8e83ac7
Merge pull request #4446 from Yonezawa-T2/neighbor_discovery_option_for_6lowpan
...
gnrc_ndp: fixed ND Option handling for 6LoWPAN
2016-01-06 14:03:43 +01:00
Yonezawa-T2
639f7dc020
gnrc_ndp: fixed ND Option handling for 6LoWPAN
...
The forms of the Source/Target Link-layer Address option for 6LoWPAN are defined
in RFC 4944 Section 8:
https://tools.ietf.org/html/rfc4944#section-8
The address is 16 bit if length is 1, 64 bit if length is 2.
2016-01-06 09:38:47 +09:00
Cenk Gündoğan
e79a471931
Merge pull request #4533 from Yonezawa-T2/gnrc_add_missing_unlock
...
gnrc_ndp_internal: add missing unlock when the pktbuf is full
2016-01-04 16:05:17 +01:00
Yonezawa-T2
38d3dc725b
gnrc_ndp_internal: add missing unlock when the pktbuf is full
...
Squashed a commit by Cenk Gündoğan <cnkgndgn@gmail.com>.
2015-12-25 11:08:28 +09:00
Johann F
adfcef4f7b
gnrc_ndp.c: parsing of SLLAO in gnrc_ndp_rtr_sol_handle
...
Do not set the link-layer address if no SLLAO was included
into the router solicitation.
2015-12-19 01:16:24 +01:00
test
432f6c34ab
ndp: use on-link flag instead of auto flag
2015-11-26 23:37:39 +01:00
Martine Lenders
6595e8c57f
Merge pull request #4174 from authmillenon/gnrc_ndp_internal/fix/send-ras-without-pio
...
gnrc_ndp_internal: send RAs even when there are no PIOs
2015-11-17 14:01:55 +01:00
Cenk Gündoğan
bf3a504691
nc: ndp: sixlowpan: remove timex.h include
2015-11-09 14:55:04 +01:00
Cenk Gündoğan
34c3267bfe
ndp: timex_t -> uint32_t
2015-11-09 14:55:04 +01:00
Cenk Gündoğan
5aaea3879f
netif: ndp: gnrc_ipv6_netif_t::retrans_timer -> uint32_t
2015-11-09 14:55:04 +01:00
Cenk Gündoğan
b59fc825a3
netif: nc: ndp: gnrc_ipv6_netif_t::reach_time -> uint32_t
2015-11-09 14:55:01 +01:00
Cenk Gündoğan
47fe901187
ndp: timex -> uint32_t for probe delay time
2015-11-09 14:54:42 +01:00
Cenk Gündoğan
42c5666357
Merge pull request #4186 from cgundogan/pr/ipv6/last_vtimers
...
network_layer: remove last occurences of vtimer
2015-11-02 15:42:50 +01:00
Cenk Gündoğan
47a02d9d07
ipv6: ndp: sixlowpan: remove vtimer includes
2015-11-02 15:02:08 +01:00
Cenk Gündoğan
83e0c45259
Merge pull request #4176 from authmillenon/gnrc_ndp/fix/stop-rs-retransmissions-on-ra
...
gnrc_ndp: stop multicast RS retransmissions on RA reception
2015-10-28 21:40:28 +01:00
Martine Lenders
23f8fecc04
Merge pull request #4157 from cgundogan/pr/nc/xtimer_nbr_sol_timer
...
nc: use xtimer for gnrc_ipv6_nc_t::nbr_sol_timer
2015-10-28 17:51:48 +01:00
Cenk Gündoğan
4297972054
nc: use xtimer for gnrc_ipv6_nc_t::nbr_sol_timer
2015-10-28 15:24:45 +01:00
Cenk Gündoğan
c78fd9f4ed
Merge pull request #4159 from cgundogan/pr/netif/xtimer_rtr_adv_timer
...
netif: use xtimer for gnrc_ipv6_netif_t::rtr_adv_timer
2015-10-28 11:09:13 +01:00
Peter Kietzmann
eaf1e29b31
Merge pull request #4179 from OlegHahm/ndp_l2_length_calculation
...
gnrc: ndp: fix calculation of L2 address length
2015-10-28 10:25:32 +01:00
Cenk Gündoğan
a979d0c72c
netif: use xtimer for gnrc_ipv6_netif_t::rtr_adv_timer
2015-10-27 20:51:34 +01:00
Cenk Gündoğan
7490dc21a0
Merge pull request #4172 from cgundogan/pr/ndp/use_correct_timer
...
nc: ndp: add/use gnrc_ipv6_nc_t::rtr_adv_timer in gnrc_ndp_rtr_sol_handle
2015-10-27 20:43:30 +01:00
Oleg Hahm
64a653496a
gnrc: ndp: fix calculation of L2 address length
...
If no source address was provided by layer 2 or someone removed it, the calculation of its length is done using the length field from the Source/Target Link-layer Address option (https://tools.ietf.org/html/rfc4861#section-4.6.1 ). The length is specified as units of 8 octets. Hence, it should be multiplied by 8, not divided.
2015-10-27 20:13:50 +01:00
Martine Lenders
8722699fb2
gnrc_ndp: stop multicast RS retransmissions on RA reception
...
6LoWPAN interfaces already do that, other interface happily continue
multicasting RSs even if a router was found.
2015-10-27 19:37:12 +01:00
Martine Lenders
ae567efc9a
gnrc_ndp_internal: send RAs even when there are no PIOs
2015-10-27 19:33:52 +01:00
Cenk Gündoğan
b993914534
nc: ndp: add and use gnrc_ipv6_nc_t::rtr_adv_timer in gnrc_ndp_rtr_sol_handle
2015-10-27 17:15:52 +01:00
Cenk Gündoğan
d587cf9cd4
netif: use xtimer for gnrc_ipv6_netif_t::rtr_sol_timer
2015-10-26 21:03:38 +01:00
Cenk Gündoğan
59a8b929f6
nc: use xtimer for gnrc_ipv6_nc_t::nbr_adv_timer
2015-10-26 16:59:16 +01:00
