From fb22cf89fec4fb5aed9df28dc43968ced17f6113 Mon Sep 17 00:00:00 2001 From: danpetry Date: Tue, 3 Jul 2018 12:05:40 +0200 Subject: [PATCH] Docs: add "allow time to ack before dismissing" --- MAINTAINING.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/MAINTAINING.md b/MAINTAINING.md index 513f540bc3..bcb44c6798 100644 --- a/MAINTAINING.md +++ b/MAINTAINING.md @@ -128,6 +128,11 @@ This could include: review - Usage of GitHub functionality, for example "Reviewers" and "Assignees" lists +#### Github etiquette + +- If there are multiple maintainers reviewing a PR, always give the other + maintainers reasonable time to ACK before dismissing their review. + [list of maintainers]: https://github.com/RIOT-OS/RIOT/wiki/Maintainers [Best Practices]: https://github.com/RIOT-OS/RIOT/wiki/Best-Practice-for-RIOT-Programming [Comparing build sizes]: https://github.com/RIOT-OS/RIOT/wiki/Comparing-build-sizes