RIOT-OS/RIOT
RIOT-OS/RIOT
1
0
Fork 0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2025-01-18 12:52:44 +01:00
Code Releases Activity

drivers/lsm6dsl: eliminate and correct casts

Browse Source 
Converting phydat_t* to lsm6dsl_3d_data_t* is not correct, but it happened
to just work because the first struct member of phydat_t will be used.

Furthermore, casting &res[0] to int16_t* is wrong. Again, it just happened
to work.
This commit is contained in:
Kees Bakker 2019-01-06 16:56:17 +01:00
parent b77c802f9b
commit d8edf6dd4e
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/lsm6dsl/lsm6dsl_saul.c
View File

@ -25,7 +25,7 @@
static int read_acc(const void *dev, phydat_t *res) static int read_acc(const void *dev, phydat_t *res)
{ {
int ret = lsm6dsl_read_acc((const lsm6dsl_t *)dev, (lsm6dsl_3d_data_t *)res); int ret = lsm6dsl_read_acc((const lsm6dsl_t *)dev, (lsm6dsl_3d_data_t *)res->val);
if (ret < 0) { if (ret < 0) {
return -ECANCELED; return -ECANCELED;
} }
@ -38,7 +38,7 @@ static int read_acc(const void *dev, phydat_t *res)
static int read_gyro(const void *dev, phydat_t *res) static int read_gyro(const void *dev, phydat_t *res)
{ {
int ret = lsm6dsl_read_gyro((const lsm6dsl_t *)dev, (lsm6dsl_3d_data_t *)res); int ret = lsm6dsl_read_gyro((const lsm6dsl_t *)dev, (lsm6dsl_3d_data_t *)res->val);
if (ret < 0) { if (ret < 0) {
return -ECANCELED; return -ECANCELED;
} }
@ -51,7 +51,7 @@ static int read_gyro(const void *dev, phydat_t *res)
static int read_temp(const void *dev, phydat_t *res) static int read_temp(const void *dev, phydat_t *res)
{ {
if (lsm6dsl_read_temp((const lsm6dsl_t *)dev, (int16_t *)&res[0]) < 0) { if (lsm6dsl_read_temp((const lsm6dsl_t *)dev, &res->val[0]) < 0) {
return -ECANCELED; return -ECANCELED;
} }
res->scale = -2; res->scale = -2;