RIOT-OS/RIOT
RIOT-OS/RIOT
1
0
Fork 0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2024-12-29 04:50:03 +01:00
Code Releases Activity

cpu/kinetis/dist-check-fcfield.sh: minor fixes

Browse Source 
- `printf "%d" ""` triggers an "invalid number" warning on ash, so
  let's use `0` as portable default for zero
- add quotes where needed to make shellcheck happy
This commit is contained in:
Marian Buschsieweke 2024-05-01 14:05:36 +02:00
parent a620a3c27f
commit d1167d9d77
No known key found for this signature in database
GPG Key ID: 77AA882EC78084E6
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
cpu/kinetis/dist/check-fcfield.sh vendored
View File

@ -12,7 +12,8 @@
# @author Joakim Nohlgård <joakim.nohlgard@eistec.se> # @author Joakim Nohlgård <joakim.nohlgard@eistec.se>
# @author Francisco Molina <francisco.molina@inria.fr> # @author Francisco Molina <francisco.molina@inria.fr>
: ${OBJDUMP:=arm-none-eabi-objdump} : "${OBJDUMP:=arm-none-eabi-objdump}"
: "${IMAGE_OFFSET:=0}"
# elf, hex or bin file to flash # elf, hex or bin file to flash
FLASHFILE="$1" FLASHFILE="$1"
@ -28,12 +29,12 @@ EXPECTED_FCFIELD="^fffffffffffffffffffffffffe..ffff$"
get_fc_field() get_fc_field()
{ {
if [ ${1##*.} = elf ]; then if [ "${1##*.}" = elf ]; then
"${OBJDUMP}" -j.fcfield -s "${1}" "${OBJDUMP}" -j.fcfield -s "${1}"
elif [ ${1##*.} = bin ]; then elif [ "${1##*.}" = bin ]; then
"${OBJDUMP}" --start-address=${FCFIELD_START} --stop-address=${FCFIELD_END} -bbinary -marm ${1} -s "${OBJDUMP}" --start-address=${FCFIELD_START} --stop-address=${FCFIELD_END} -bbinary -marm "${1}" -s
elif [ ${1##*.} = hex ]; then elif [ "${1##*.}" = hex ]; then
"${OBJDUMP}" --start-address=${FCFIELD_START} --stop-address=${FCFIELD_END} ${1} -s "${OBJDUMP}" --start-address=${FCFIELD_START} --stop-address=${FCFIELD_END} "${1}" -s
else else
echo "Unknown file extension: ${1##*.}" echo "Unknown file extension: ${1##*.}"
exit 1 exit 1
@ -51,16 +52,16 @@ if [ $# -ne 1 ]; then
exit 2 exit 2
fi fi
if [ $(printf '%d' "${IMAGE_OFFSET}") -ge $(printf '%d' "${FCFIELD_END}") ]; then if [ "$(printf '%d' "${IMAGE_OFFSET}")" -ge "$(printf '%d' "${FCFIELD_END}")" ]; then
echo "Value in fcfield is not checked when flashing at \$IMAGE_OFFSET >= 0x410" echo "Value in fcfield is not checked when flashing at \$IMAGE_OFFSET >= 0x410"
exit 0 exit 0
elif [ 0 -lt $(printf '%d' "${IMAGE_OFFSET}") ] && [ $(printf '%d' "${IMAGE_OFFSET}") -lt $(printf '%d' "${FCFIELD_END}") ]; then elif [ 0 -lt "$(printf '%d' "${IMAGE_OFFSET}")" ] && [ "$(printf '%d' "${IMAGE_OFFSET}")" -lt "$(printf '%d' "${FCFIELD_END}")" ]; then
echo "Error: flashing with 0 < \$IMAGE_OFFSET < 0x410 is currently not handled" echo "Error: flashing with 0 < \$IMAGE_OFFSET < 0x410 is currently not handled"
exit 1 exit 1
elif ! filter_fc_field ${FLASHFILE} ${FCFIELD_AWK_REGEX} | grep -q "${EXPECTED_FCFIELD}"; then elif ! filter_fc_field "${FLASHFILE}" "${FCFIELD_AWK_REGEX}" | grep -q "${EXPECTED_FCFIELD}"; then
echo "Danger of bricking the device during flash!" echo "Danger of bricking the device during flash!"
echo "Flash configuration field of ${FLASHFILE}:" echo "Flash configuration field of ${FLASHFILE}:"
get_fc_field ${FLASHFILE} get_fc_field "${FLASHFILE}"
echo "Abort flash procedure!" echo "Abort flash procedure!"
exit 1 exit 1
fi fi