RIOT-OS/RIOT
RIOT-OS/RIOT
1
0
Fork 0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2024-12-29 04:50:03 +01:00
Code Releases Activity

static_tests/rust: Address shellcheck lints

Browse Source 
The pure POSIX way to do `for x in $(find ...)` right involves a
tempfile, thus limiting to bash.
This commit is contained in:
chrysn 2024-10-03 11:45:56 +02:00
parent 69a89b80ca
commit d0299deb33
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
dist/tools/cargo-checks/check.sh vendored
View File

@ -1,21 +1,17 @@
#!/bin/sh #!/bin/bash
set -eu set -eu
FAILURES="" FAILURES=""
# This is a Make based environment, therefore we don't have funny names to take while IFS= read -r -d '' CARGOTOML
# care of, and anyone who can cause commands to be run by injecting files can
# just as well modify the scripts being run. (Otherwise we'd need to go through
# a less readable print0 / read).
for CARGOTOML in `find -name Cargo.toml`
do do
if cargo fmt --quiet --check --manifest-path "${CARGOTOML}"; then if cargo fmt --quiet --check --manifest-path "${CARGOTOML}"; then
continue continue
else else
FAILURES="${FAILURES} ${CARGOTOML%Cargo.toml}" FAILURES="${FAILURES} ${CARGOTOML%Cargo.toml}"
fi fi
done done < <(find . -name Cargo.toml -print0)
if [ x"" != x"${FAILURES}" ]; then if [ x"" != x"${FAILURES}" ]; then
echo "Some Rust files are following rustfmt, in particular in:" echo "Some Rust files are following rustfmt, in particular in:"
@ -23,7 +19,7 @@ if [ x"" != x"${FAILURES}" ]; then
echo "You can format the code locally using:" echo "You can format the code locally using:"
echo echo
echo "find -name Cargo.toml -exec cargo fmt --manifest-path '{}' ';'" echo "find -name Cargo.toml -exec cargo fmt --manifest-path '{}' ';'"
if [ ! -z "${GITHUB_RUN_ID:-}" ]; then if [ -n "${GITHUB_RUN_ID:-}" ]; then
echo echo
echo "The author of this test regrets not knowing how to provide an easy way to just click a button here that provides the right fixup commits." echo "The author of this test regrets not knowing how to provide an easy way to just click a button here that provides the right fixup commits."
fi fi