RIOT-OS/RIOT
RIOT-OS/RIOT
1
0
Fork 0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2024-12-29 04:50:03 +01:00
Code Releases Activity

sys/shell/ping: add protection from icmp packet overflow

Browse Source
This commit is contained in:
krzysztof-cabaj 2023-09-16 12:20:21 -04:00
parent d7000477d4
commit be7ae57891
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
sys/shell/cmds/gnrc_icmpv6_echo.c
View File

@ -172,6 +172,7 @@ static int _configure(int argc, char **argv, _ping_data_t *data)
{ {
char *cmdname = argv[0]; char *cmdname = argv[0];
int res = 1; int res = 1;
int value;
/* parse command line arguments */ /* parse command line arguments */
for (int i = 1; i < argc; i++) { for (int i = 1; i < argc; i++) {
@ -207,7 +208,13 @@ static int _configure(int argc, char **argv, _ping_data_t *data)
/* intentionally falls through */ /* intentionally falls through */
case 's': case 's':
if ((++i) < argc) { if ((++i) < argc) {
data->datalen = atoi(argv[i]); value = atoi(argv[i]);
if ((value < 0) || ((unsigned)value > (UINT16_MAX - sizeof(icmpv6_hdr_t)))) {
printf("ICMPv6 datagram size should be in range 0-65527.\n");
return -1;
}
data->datalen = value;
continue; continue;
} }
/* intentionally falls through */ /* intentionally falls through */