Merge pull request #18759 from gschorcht/drivers/usbdev_synopsys_dwc2_fixes

drivers/usbdev_synopsys_dwc2: small fixes

cpu/esp32/Kconfig.esp32s2

@@ -26,7 +26,7 @@ config CPU_FAM_ESP32S2
     select MODULE_PS if MODULE_SHELL
     select MODULE_PTHREAD if MODULE_CPP
     select MODULE_RTT_RTC if HAS_PERIPH_RTT && MODULE_PERIPH_RTC
-    select MODULE_USBDEV_SYNOPSYS_DWC2 if HAS_PERIPH_USBDEV && MODULE_PERIPH_USBDEV
+    select MODULE_USBDEV_SYNOPSYS_DWC2 if MODULE_PERIPH_USBDEV
     imply MODULE_NEWLIB_NANO
 
 config CPU_FAM

cpu/esp32/Kconfig.esp32s3

@@ -33,7 +33,7 @@ config CPU_FAM_ESP32S3
     select MODULE_PS if MODULE_SHELL
     select MODULE_PTHREAD if MODULE_CPP
     select MODULE_RTT_RTC if HAS_PERIPH_RTT && MODULE_PERIPH_RTC
-    select MODULE_USBDEV_SYNOPSYS_DWC2 if HAS_PERIPH_USBDEV && MODULE_PERIPH_USBDEV
+    select MODULE_USBDEV_SYNOPSYS_DWC2 if MODULE_PERIPH_USBDEV
     imply MODULE_NEWLIB_NANO
 
 config CPU_FAM

cpu/esp32/Makefile.dep

@@ -160,7 +160,6 @@ endif
 ifneq (,$(filter periph_usbdev,$(USEMODULE)))
   USEMODULE += esp_idf_usb
   USEMODULE += usbdev_synopsys_dwc2
-  USEMODULE += ztimer_msec
 endif
 
 ifneq (,$(filter shell,$(USEMODULE)))

cpu/esp32/include/periph_cpu_esp32s2.h

@@ -264,9 +264,7 @@ extern "C" {
 /**
  * @brief   Total size of the FIFO
  */
-#ifndef DWC2_USB_OTG_FS_TOTAL_FIFO_SIZE
 #define DWC2_USB_OTG_FS_TOTAL_FIFO_SIZE (1024U)
-#endif
 
 /**
  * @brief   Buffers have to be word aligned for DMA

cpu/esp32/include/periph_cpu_esp32s3.h

@@ -265,9 +265,7 @@ extern "C" {
 /**
  * @brief   Total size of the FIFO
  */
-#ifndef DWC2_USB_OTG_FS_TOTAL_FIFO_SIZE
 #define DWC2_USB_OTG_FS_TOTAL_FIFO_SIZE (1024U)
-#endif
 
 /**
  * @brief   Buffers have to be word aligned for DMA

cpu/stm32/include/usbdev_stm32.h

@@ -81,7 +81,7 @@ extern "C" {
 /**
  * @brief USB OTG FS FIFO reception buffer space in 32-bit words
  *
- * Used as shared FIFO for reception of all OUT transfers
+ * Used as shared FIFO for reception of all OUT transfers from the host
  *
  * @note The application might have to increase this when dealing with large
  *       isochronous transfers
@@ -99,6 +99,38 @@ extern "C" {
 #define DWC2_USB_OTG_HS_RX_FIFO_SIZE   (512U)
 #endif
 
+/**
+ * @brief USB OTG FS FIFO total size
+ *
+ * Some device families (F7 and L4) forgot to define the FS device FIFO size
+ * in their vendor headers. This define sets it to the value from the
+ * reference manual.
+ */
+#ifndef USB_OTG_FS_TOTAL_FIFO_SIZE
+#define USB_OTG_FS_TOTAL_FIFO_SIZE      (1280U)
+#endif
+
+/**
+ * @brief USB OTG FS FIFO total size
+ *
+ * Some device families (F7 and L4) forgot to define the HS device FIFO size
+ * in their vendor headers. This define sets it to the value from the
+ * reference manual.
+ */
+#ifndef USB_OTG_HS_TOTAL_FIFO_SIZE
+#define USB_OTG_HS_TOTAL_FIFO_SIZE      (4096U)
+#endif
+
+/**
+ * @brief USB OTG FS FIFO total size
+ */
+#define DWC2_USB_OTG_FS_TOTAL_FIFO_SIZE USB_OTG_FS_TOTAL_FIFO_SIZE
+
+/**
+ * @brief USB OTG HS FIFO total size
+ */
+#define DWC2_USB_OTG_HS_TOTAL_FIFO_SIZE USB_OTG_HS_TOTAL_FIFO_SIZE
+
 /**
  * @brief Use the built-in DMA controller of the HS peripheral when possible
  */

drivers/Makefile.dep

@@ -209,6 +209,7 @@ endif
 
 ifneq (,$(filter usbdev_synopsys_dwc2,$(USEMODULE)))
   FEATURES_REQUIRED += periph_usbdev
+  USEMODULE += ztimer_msec
 endif
 
 ifneq (,$(filter vcnl40%0,$(USEMODULE)))

drivers/usbdev_synopsys_dwc2/usbdev_synopsys_dwc2.c

@@ -93,20 +93,6 @@
 #define DWC2_PKTSTS_SETUP_COMP     0x04    /**< Rx fifo setup complete */
 #define DWC2_PKTSTS_SETUP_UPDT     0x06    /**< Rx fifo setup update   */
 
-/* Some device families (F7 and L4) forgot to define the FS device FIFO size  *
- * in their vendor headers. This define sets it to the value from the         *
- * reference manual                                                           */
-#ifndef USB_OTG_FS_TOTAL_FIFO_SIZE
-#define USB_OTG_FS_TOTAL_FIFO_SIZE      (1280U)
-#endif
-
-/* Some device families (F7 and L4) forgot to define the HS device FIFO size  *
- * in their vendor headers. This define sets it to the value from the         *
- * reference manual                                                           */
-#ifndef USB_OTG_HS_TOTAL_FIFO_SIZE
-#define USB_OTG_HS_TOTAL_FIFO_SIZE      (4096U)
-#endif
-
 /* minimum depth of an individual transmit FIFO */
 #define DWC2_USB_OTG_FIFO_MIN_WORD_SIZE (16U)
 /* Offset for OUT endpoints in a shared IN/OUT endpoint bit flag register */
@@ -472,14 +458,14 @@ static size_t _total_fifo_size(const dwc2_usb_otg_fshs_config_t *conf)
 {
     if (conf->type == DWC2_USB_OTG_FS) {
 #ifdef DWC2_USB_OTG_FS_ENABLED
-        return USB_OTG_FS_TOTAL_FIFO_SIZE;
+        return DWC2_USB_OTG_FS_TOTAL_FIFO_SIZE;
 #else
         return 0;
 #endif  /* DWC2_USB_OTG_FS_ENABLED */
     }
     else {
 #ifdef DWC2_USB_OTG_HS_ENABLED
-        return USB_OTG_HS_TOTAL_FIFO_SIZE;
+        return DWC2_USB_OTG_HS_TOTAL_FIFO_SIZE;
 #else
         return 0;
 #endif  /* DWC2_USB_OTG_HS_ENABLED */