From a51d4bd7d9491bdd78e6d98906cc6151fbdb3bd4 Mon Sep 17 00:00:00 2001 From: Marian Buschsieweke Date: Thu, 21 Nov 2024 20:23:30 +0100 Subject: [PATCH] tests/periph/selftest_shield: fix logic to enable UART test We cannot use the D0/D1 UART if it is also used for STDIO. However, the logic did not take into account whether `stdio_uart` was used at all. This fixes the issue. --- tests/periph/selftest_shield/main.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/periph/selftest_shield/main.c b/tests/periph/selftest_shield/main.c index 9ab2f7c4a5..1cb19dff9e 100644 --- a/tests/periph/selftest_shield/main.c +++ b/tests/periph/selftest_shield/main.c @@ -55,10 +55,14 @@ /* In order to run the periph_uart test all of the following needs to be true: * - periph_uart needs to be used * - an I/O mapping for the UART at D0/D1 needs to be provided - * - this UART dev is not busy with stdio + * - this UART dev is not busy with stdio (either not using `stdio_uart` or a different UART is used for stdio) */ #if defined(ARDUINO_UART_D0D1) && defined(MODULE_PERIPH_UART) -# define ENABLE_UART_TEST (STDIO_UART_DEV != ARDUINO_UART_D0D1) +# if MODULE_STDIO_UART +# define ENABLE_UART_TEST (STDIO_UART_DEV != ARDUINO_UART_D0D1) +# else +# define ENABLE_UART_TEST 1 +# endif # define UART_TEST_DEV ARDUINO_UART_D0D1 #else # define ENABLE_UART_TEST 0