RIOT-OS/RIOT
RIOT-OS/RIOT
1
0
Fork 0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2024-12-29 04:50:03 +01:00
Code Releases Activity

xtimer/xtimer.c: ensure modifing mutex is done with interrupt disabled

Browse Source 
if xtimer_set spins the callback is executed in the thread context.

comment to explain irq_disable
and when this line could be removed
(when xtimer stops executing the callback funtion from thread context)
This commit is contained in:
JulianHolzwarth 2019-05-29 17:36:47 +02:00
parent ca8169f323
commit a321dfc51d
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
sys/xtimer/xtimer.c
View File

@ -239,6 +239,15 @@ int _xtimer_msg_receive_timeout(msg_t *msg, uint32_t timeout_ticks)
static void _mutex_timeout(void *arg)
{
/* interupts a disabled because xtimer can spin
* if xtimer_set spins the callback is executed
* in the thread context
*
* If the xtimer spin is fixed in the future
* interups disable/restore can be removed
*/
unsigned irqstate = irq_disable();
mutex_thread_t *mt = (mutex_thread_t *)arg;
mt->timeout = 1;
@ -249,6 +258,8 @@ static void _mutex_timeout(void *arg)
}
sched_set_status(mt->thread, STATUS_PENDING);
thread_yield_higher();
irq_restore(irqstate);
}
int xtimer_mutex_lock_timeout(mutex_t *mutex, uint64_t timeout)