RIOT-OS/RIOT
RIOT-OS/RIOT
1
0
Fork 0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2024-12-29 04:50:03 +01:00
Code Releases Activity

MAINTAINING.md: extend Github ettiquette for multi-maintainer review

Browse Source
This commit is contained in:
Martine Lenders 2018-09-20 13:57:16 +02:00 committed by Martine Lenders
parent 67694c3119
commit 96b2928e02
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
MAINTAINING.md
View File

@ -141,8 +141,17 @@ simple approving ACK might suffice.
#### Github etiquette #### Github etiquette
- If there are multiple maintainers reviewing a PR, always give the other It is good etiquette to describe what you reviewed, even if you gave the PR a
maintainers reasonable time to ACK before dismissing their review. full review and gave your approval. This way the contributor and other
maintainers are able to follow your thought process.
Maintainers should only assign themselves to PRs and shouldn't assign other
maintainers. You can however request reviews from other maintainers or
contributors, either by mentioning them in a comment or selecting them in
GitHub's review sidebar.
If there are multiple maintainers reviewing a PR, always give the other
maintainers reasonable time to ACK before dismissing their review.
[list of maintainers]: https://github.com/RIOT-OS/RIOT/wiki/Maintainers [list of maintainers]: https://github.com/RIOT-OS/RIOT/wiki/Maintainers
[Best Practices]: https://github.com/RIOT-OS/RIOT/wiki/Best-Practice-for-RIOT-Programming [Best Practices]: https://github.com/RIOT-OS/RIOT/wiki/Best-Practice-for-RIOT-Programming