From 6e7fa9e9e0be98b04f0d99bfc6b246aaad754d0d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ga=C3=ABtan=20Harter?= Date: Wed, 16 Jan 2019 16:13:22 +0100 Subject: [PATCH] tests/posix_semaphore: private sub functions for tests libs While trying python test libraries, like pytest, the automatic test collection detects the `testNUM` functions as tests but does not know the `term` argument and fails. This declares them as private to only find `testfunc(child)` entry point. Another solution could have been to use `testNUM(child)` and rename `testfunc` to `main` but would not match other tests. --- tests/posix_semaphore/tests/01-run.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/posix_semaphore/tests/01-run.py b/tests/posix_semaphore/tests/01-run.py index b9aa9d76d1..582b07a104 100755 --- a/tests/posix_semaphore/tests/01-run.py +++ b/tests/posix_semaphore/tests/01-run.py @@ -10,7 +10,7 @@ import sys from testrunner import run -def test1(term): +def _test1(term): term.expect_exact("######################### TEST1:") term.expect_exact("first: sem_init") term.expect_exact("first: thread create") @@ -33,7 +33,7 @@ def test1(term): term.expect_exact("first: end") -def test2(term): +def _test2(term): term.expect_exact("######################### TEST2:") term.expect_exact("first: sem_init") term.expect_exact("first: thread create: 5") @@ -64,7 +64,7 @@ def test2(term): term.expect_exact("Back in main thread.") -def test3(term): +def _test3(term): term.expect_exact("######################### TEST3:") term.expect_exact("first: sem_init s1") term.expect_exact("first: sem_init s2") @@ -81,7 +81,7 @@ def test3(term): term.expect_exact("Thread 2 woke up after waiting for s1.") -def test4(term): +def _test4(term): term.expect_exact("######################### TEST4:") term.expect_exact("first: sem_init s1") term.expect_exact("first: wait 1 sec for s1") @@ -90,10 +90,10 @@ def test4(term): def testfunc(child): - test1(child) - test2(child) - test3(child) - test4(child) + _test1(child) + _test2(child) + _test3(child) + _test4(child) child.expect("######################### DONE")