RIOT-OS/RIOT
RIOT-OS/RIOT
1
0
Fork 0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2025-01-18 12:52:44 +01:00
Code Releases Activity

cpu/esp32: fixes serious memory leak in esp_wifi

Browse Source 
The buffer given by the WiFi driver as parameter eb has to be freed explicitly. Otherwise the esp_wifi_netdev stops working after some seconds.
This commit is contained in:
Gunar Schorcht 2019-01-13 17:14:20 +01:00 committed by Schorcht
parent 3ef35e1b78
commit 8a1da21b1a
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
cpu/esp32/esp-wifi/esp_wifi_netdev.c
View File

@ -74,12 +74,22 @@ esp_err_t _esp_wifi_rx_cb(void *buffer, uint16_t len, void *eb)
{ {
DEBUG("%s: buf=%p len=%d eb=%p\n", __func__, buffer, len, eb); DEBUG("%s: buf=%p len=%d eb=%p\n", __func__, buffer, len, eb);
CHECK_PARAM_RET (buffer != NULL, -EINVAL); if ((buffer == NULL) || (len >= ETHERNET_DATA_LEN)) {
CHECK_PARAM_RET (len <= ETHERNET_DATA_LEN, -EINVAL); if (eb != NULL) {
esp_wifi_internal_free_rx_buffer(eb);
}
return ESP_ERR_INVALID_ARG;
}
mutex_lock(&_esp_wifi_dev.dev_lock); mutex_lock(&_esp_wifi_dev.dev_lock);
/* copy the buffer and free WiFi driver buffer */
memcpy(_esp_wifi_dev.rx_buf, buffer, len); memcpy(_esp_wifi_dev.rx_buf, buffer, len);
if (eb) {
esp_wifi_internal_free_rx_buffer(eb);
}
/* trigger netdev event to read the data */
_esp_wifi_dev.rx_len = len; _esp_wifi_dev.rx_len = len;
_esp_wifi_dev.event = SYSTEM_EVENT_WIFI_RX_DONE; _esp_wifi_dev.event = SYSTEM_EVENT_WIFI_RX_DONE;
_esp_wifi_dev.netdev.event_callback(&_esp_wifi_dev.netdev, NETDEV_EVENT_ISR); _esp_wifi_dev.netdev.event_callback(&_esp_wifi_dev.netdev, NETDEV_EVENT_ISR);