RIOT-OS/RIOT
RIOT-OS/RIOT
1
0
Fork 0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2024-12-29 04:50:03 +01:00
Code Releases Activity

sys/analog_util/dac_util: fix truncation bug

Browse Source 
In `dac_util_map(...)` the expression `((value - min) * UINT16_MAX)` was
cast to a 16 bit unsigned, then divided by `(max - min)`. This means
that anytime `(value - min) != 0` the numerator was truncated prior to
being divided and then returned.

This patch modifies the expression so that the downcast to 16 bits is
performed as the last operation.
This commit is contained in:
Joshua DeWeese 2022-12-09 13:42:28 -05:00
parent ff2ebcfce0
commit 86d751d4d3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/analog_util/dac_util.c
View File

@ -24,7 +24,7 @@
uint16_t dac_util_map(int value, int min, int max)
{
return (uint16_t)((value - min) * UINT16_MAX) / (max - min);
return (uint16_t)(((value - min) * UINT16_MAX) / (max - min));
}
uint16_t dac_util_mapf(float value, float min, float max)