RIOT-OS/RIOT
RIOT-OS/RIOT
1
0
Fork 0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2024-12-29 04:50:03 +01:00
Code Releases Activity

Merge pull request #14259 from fjmolinas/pr_rtt_min_offset

Browse Source 
drivers/periph/rtt: introduce RTT_MIN_OFFSET
This commit is contained in:
Alexandre Abadie 2020-06-16 16:22:04 +02:00 committed by GitHub
commit 80023c408a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 22 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
boards/samr21-xpro/include/periph_conf.h
View File

@ -298,6 +298,7 @@ static const i2c_conf_t i2c_config[] = {
#define RTT_IRQ_PRIO 10
#define RTT_ISR isr_rtc
#define RTT_MAX_VALUE (0xffffffff)
#define RTT_MIN_OFFSET (10U)
#define RTT_FREQUENCY (32768U) /* in Hz. For changes see `rtt.c` */
#define RTT_RUNSTDBY (1) /* Keep RTT running in sleep states */
/** @} */

18
drivers/include/periph/rtt.h
View File

@ -61,6 +61,24 @@ extern "C" {
#define RTT_MAX_VALUE
#endif
/**
* @def RTT_MIN_OFFSET
*
* @brief The minimum offset to correctly set an rtt callback.
*
* If the callback is taking into account rtt_get_counter() then the rtt
* might advance right between the call to rtt_get_counter() and
* rtt_set_alarm(). If that happens with val==1, the alarm would be
* set to the current time, which would then underflow. To avoid this,
* the alarm should be set at least two ticks in the future.
*
* This value can vary depending on the platform.
*
*/
#ifndef RTT_MIN_OFFSET
#define RTT_MIN_OFFSET (2U)
#endif
#ifndef RTT_FREQUENCY
/* Allow mock-RTT for unit tests */
#ifdef MOCK_RTT_FREQUENCY

10
sys/ztimer/periph_rtt.c
View File

@ -26,10 +26,6 @@
#define ENABLE_DEBUG (0)
#include "debug.h"
#ifndef RTT_MIN_VALUE
#define RTT_MIN_VALUE (2U)
#endif
static void _ztimer_periph_rtt_callback(void *arg)
{
ztimer_handler((ztimer_clock_t *)arg);
@ -37,17 +33,17 @@ static void _ztimer_periph_rtt_callback(void *arg)
static void _ztimer_periph_rtt_set(ztimer_clock_t *clock, uint32_t val)
{
if (val < RTT_MIN_VALUE) {
if (val < RTT_MIN_OFFSET) {
/* the rtt might advance right between the call to rtt_get_counter()
* and rtt_set_alarm(). If that happens with val==1, we'd set an alarm
* to the current time, which would then underflow. To avoid this, we
* set the alarm at least two ticks in the future. TODO: confirm this
* is sufficient, or conceive logic to lower this value.
*
* @note RTT_MIN_VALUE defaults to 2, but some platforms might have
* @note RTT_MIN_OFFSET defaults to 2, but some platforms might have
* different values.
*/
val = RTT_MIN_VALUE;
val = RTT_MIN_OFFSET;
}
unsigned state = irq_disable();