RIOT-OS/RIOT
RIOT-OS/RIOT
1
0
Fork 0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2024-12-29 04:50:03 +01:00
Code Releases Activity

gnrc_ipv6: check validity of preconfigured source on send

Browse Source 
If an address was pre-configured by the upper layer its validity is
currently ignored. It is neither checked if the address is on the
interface at all nor is it checked if it is valid.

This change provides a fix for that by checking both facts.
This commit is contained in:
Martine S. Lenders 2019-08-06 15:01:55 +02:00
parent b388a5b3d2
commit 7f2cc4f0b3
1 changed files with 31 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
sys/net/gnrc/network_layer/ipv6/gnrc_ipv6.c
View File

@ -351,6 +351,37 @@ static int _fill_ipv6_hdr(gnrc_netif_t *netif, gnrc_pktsnip_t *ipv6)
/* Otherwise leave unspecified */
}
}
else {
bool invalid_src;
int idx;
gnrc_netif_acquire(netif);
invalid_src = ((idx = gnrc_netif_ipv6_addr_idx(netif, &hdr->src)) == -1) ||
(gnrc_netif_ipv6_addr_get_state(netif, idx) != GNRC_NETIF_IPV6_ADDRS_FLAGS_STATE_VALID);
gnrc_netif_release(netif);
if (invalid_src) {
#if GNRC_IPV6_NIB_CONF_6LN
gnrc_pktsnip_t *icmpv6 = gnrc_pktsnip_search_type(ipv6,
GNRC_NETTYPE_ICMPV6);
icmpv6_hdr_t *icmpv6_hdr;
if (icmpv6 != NULL) {
icmpv6_hdr = icmpv6->data;
}
if ((icmpv6 == NULL) ||
((icmpv6_hdr->type != ICMPV6_RTR_SOL) &&
(icmpv6_hdr->type != ICMPV6_NBR_SOL))) {
DEBUG("ipv6: preset packet source address %s is invalid\n",
ipv6_addr_to_str(addr_str, &hdr->src, sizeof(addr_str)));
return -EADDRNOTAVAIL;
}
#else /* GNRC_IPV6_NIB_CONF_6LN */
DEBUG("ipv6: preset packet source address %s is invalid\n",
ipv6_addr_to_str(addr_str, &hdr->src, sizeof(addr_str)));
return -EADDRNOTAVAIL;
#endif /* GNRC_IPV6_NIB_CONF_6LN */
}
}
DEBUG("ipv6: write protect up to payload to calculate checksum\n");
payload = ipv6;