From 790bd989f729111dd844019ad256d67d40910f50 Mon Sep 17 00:00:00 2001
From: Kees Bakker <kees@ijzerbout.nl>
Date: Sat, 20 Jan 2024 21:48:19 +0100
Subject: [PATCH] tests/periph/uart: redo implementation of changing eol

---
 tests/periph/uart/main.c | 47 ++++++++++++++++++++--------------------
 1 file changed, 23 insertions(+), 24 deletions(-)

diff --git a/tests/periph/uart/main.c b/tests/periph/uart/main.c
index b583c02e64..e8989cc080 100644
--- a/tests/periph/uart/main.c
+++ b/tests/periph/uart/main.c
@@ -59,16 +59,11 @@
 #define STX 0x2
 #endif
 
-static enum {
-    NEWLINE_CR   = 2,
-    NEWLINE_NL   = 3,
-    NEWLINE_CRNL = 4,
-} _line_end = NEWLINE_NL;
-static const uint8_t newline[] = { '\r', '\n' };
+static char *_endline = "\n";
 
 static void _write_newline(uart_t dev)
 {
-    uart_write(dev, &newline[_line_end & 1], _line_end >> 1);
+    uart_write(dev, (uint8_t *)_endline, strlen(_endline));
 }
 
 typedef struct {
@@ -376,25 +371,27 @@ static int cmd_test(int argc, char **argv)
     return 0;
 }
 
-static int cmd_newline(int argc, char **argv)
+static int cmd_eol_cr(int argc, char **argv)
 {
-    static const char *modes[] = {
-        "<CR>", "<NL>", "<CR><NL>"
-    };
+    (void)argc;
+    (void)argv;
+    _endline = "\r";
+    return 0;
+}
 
-    if (argc > 1) {
-        int sel = atoi(argv[1]);
-        if (sel < 3) {
-            _line_end = sel + NEWLINE_CR;
-        }
-    }
-
-    for (unsigned i = 0; i < ARRAY_SIZE(modes); ++i) {
-        char selected = (unsigned)_line_end - NEWLINE_CR == i
-                      ? '>' : ' ';
-        printf("%c%u: %s\n", selected, i, modes[i]);
-    }
+static int cmd_eol_lf(int argc, char **argv)
+{
+    (void)argc;
+    (void)argv;
+    _endline = "\n";
+    return 0;
+}
 
+static int cmd_eol_crlf(int argc, char **argv)
+{
+    (void)argc;
+    (void)argv;
+    _endline = "\r\n";
     return 0;
 }
 
@@ -405,7 +402,9 @@ static const shell_command_t shell_commands[] = {
 #endif
     { "send", "Send a string through given UART device", cmd_send },
     { "test", "Run an automated test on a UART with RX and TX connected", cmd_test },
-    { "nl", "Set line ending", cmd_newline },
+    { "eol_cr", "Set CR as the end-of-line for send", cmd_eol_cr },
+    { "eol_crlf", "Set CRLF as the end-of-line for send", cmd_eol_crlf },
+    { "eol_lf", "Set LF as the end-of-line for send (default)", cmd_eol_lf },
     { NULL, NULL, NULL }
 };