From 6f67e75f90c041ab5aeee9370e581dc5a099db76 Mon Sep 17 00:00:00 2001 From: smlng Date: Tue, 14 Nov 2017 11:03:26 +0100 Subject: [PATCH] tests: remove DEVELHELP from per test Makefiles --- tests/conn_can/Makefile | 2 -- tests/cpp11_condition_variable/Makefile | 5 ----- tests/cpp11_mutex/Makefile | 5 ----- tests/cpp11_thread/Makefile | 5 ----- tests/driver_at30tse75x/Makefile | 2 -- tests/driver_at86rf2xx/Makefile | 2 -- tests/driver_kw2xrf/Makefile | 2 -- tests/driver_sx127x/Makefile | 2 -- tests/driver_xbee/Makefile | 5 ----- tests/fault_handler/Makefile | 2 -- tests/gnrc_ipv6_ext/Makefile | 5 ----- tests/gnrc_ipv6_nib/Makefile | 1 - tests/gnrc_ipv6_nib_6ln/Makefile | 1 - tests/gnrc_netif/Makefile | 1 - tests/gnrc_sixlowpan/Makefile | 5 ----- tests/gnrc_sock_dns/Makefile | 2 -- tests/gnrc_sock_ip/Makefile | 1 - tests/gnrc_sock_udp/Makefile | 1 - tests/gnrc_tcp_client/Makefile | 5 ----- tests/gnrc_tcp_server/Makefile | 5 ----- tests/gnrc_udp/Makefile | 2 -- tests/lwip_sock_ip/Makefile | 1 - tests/lwip_sock_tcp/Makefile | 1 - tests/lwip_sock_udp/Makefile | 1 - tests/lwmac/Makefile | 5 ----- tests/malloc/Makefile | 5 ----- tests/mpu_stack_guard/Makefile | 2 -- tests/od/Makefile | 5 ----- tests/openthread/Makefile | 5 ----- tests/pkg_microcoap/Makefile | 5 ----- tests/ps_schedstatistics/Makefile | 1 - tests/sntp/Makefile | 5 ----- tests/ssp/Makefile | 3 --- 33 files changed, 100 deletions(-) diff --git a/tests/conn_can/Makefile b/tests/conn_can/Makefile index 01345461b6..fe31e89978 100644 --- a/tests/conn_can/Makefile +++ b/tests/conn_can/Makefile @@ -6,8 +6,6 @@ BOARD_INSUFFICIENT_MEMORY := chronos msb-430 msb-430h nucleo32-f031 nucleo32-f04 nucleo-l053 stm32f0discovery telosb wsn430-v1_3b \ wsn430-v1_4 z1 - -CFLAGS += -DDEVELHELP CFLAGS += -DLOG_LEVEL=LOG_ALL USEMODULE += shell diff --git a/tests/cpp11_condition_variable/Makefile b/tests/cpp11_condition_variable/Makefile index 68849e0c47..cb2c051468 100644 --- a/tests/cpp11_condition_variable/Makefile +++ b/tests/cpp11_condition_variable/Makefile @@ -8,11 +8,6 @@ include ../Makefile.tests_common # not pull in all C++ locale code whenever exceptions are used. BOARD_INSUFFICIENT_MEMORY := nucleo-f334 spark-core stm32f0discovery -# Comment this out to disable code in RIOT that does safety checking -# which is not needed in a production environment but helps in the -# development process: -CFLAGS += -DDEVELHELP - # If you want to add some extra flags when compile c++ files, add these flags # to CXXEXFLAGS variable CXXEXFLAGS += -std=c++11 diff --git a/tests/cpp11_mutex/Makefile b/tests/cpp11_mutex/Makefile index c763f90177..6fc5cfd70f 100644 --- a/tests/cpp11_mutex/Makefile +++ b/tests/cpp11_mutex/Makefile @@ -8,11 +8,6 @@ include ../Makefile.tests_common # not pull in all C++ locale code whenever exceptions are used. BOARD_INSUFFICIENT_MEMORY := nucleo-f334 spark-core stm32f0discovery -# Comment this out to disable code in RIOT that does safety checking -# which is not needed in a production environment but helps in the -# development process: -CFLAGS += -DDEVELHELP - # If you want to add some extra flags when compile c++ files, add these flags # to CXXEXFLAGS variable CXXEXFLAGS += -std=c++11 diff --git a/tests/cpp11_thread/Makefile b/tests/cpp11_thread/Makefile index 68849e0c47..cb2c051468 100644 --- a/tests/cpp11_thread/Makefile +++ b/tests/cpp11_thread/Makefile @@ -8,11 +8,6 @@ include ../Makefile.tests_common # not pull in all C++ locale code whenever exceptions are used. BOARD_INSUFFICIENT_MEMORY := nucleo-f334 spark-core stm32f0discovery -# Comment this out to disable code in RIOT that does safety checking -# which is not needed in a production environment but helps in the -# development process: -CFLAGS += -DDEVELHELP - # If you want to add some extra flags when compile c++ files, add these flags # to CXXEXFLAGS variable CXXEXFLAGS += -std=c++11 diff --git a/tests/driver_at30tse75x/Makefile b/tests/driver_at30tse75x/Makefile index 00c8f12051..5a897edca5 100644 --- a/tests/driver_at30tse75x/Makefile +++ b/tests/driver_at30tse75x/Makefile @@ -6,6 +6,4 @@ USEMODULE += at30tse75x USEMODULE += shell USEMODULE += shell_commands -CFLAGS += -DDEVELHELP - include $(RIOTBASE)/Makefile.include diff --git a/tests/driver_at86rf2xx/Makefile b/tests/driver_at86rf2xx/Makefile index 991683fdb7..5bcf0fa9aa 100644 --- a/tests/driver_at86rf2xx/Makefile +++ b/tests/driver_at86rf2xx/Makefile @@ -29,6 +29,4 @@ DRIVER ?= at86rf231 # include the selected driver USEMODULE += $(DRIVER) -CFLAGS += -DDEVELHELP - include $(RIOTBASE)/Makefile.include diff --git a/tests/driver_kw2xrf/Makefile b/tests/driver_kw2xrf/Makefile index 133f35e853..e462fc3cb5 100644 --- a/tests/driver_kw2xrf/Makefile +++ b/tests/driver_kw2xrf/Makefile @@ -16,6 +16,4 @@ DRIVER ?= kw2xrf # finally include the actual chosen driver USEMODULE += $(DRIVER) -CFLAGS += -DDEVELHELP - include $(RIOTBASE)/Makefile.include diff --git a/tests/driver_sx127x/Makefile b/tests/driver_sx127x/Makefile index 5370698872..fa6ee5c378 100644 --- a/tests/driver_sx127x/Makefile +++ b/tests/driver_sx127x/Makefile @@ -18,6 +18,4 @@ USEMODULE += ${DRIVER} FEATURES_REQUIRED ?= periph_spi FEATURES_REQUIRED ?= periph_gpio -CFLAGS += -DDEVELHELP - include $(RIOTBASE)/Makefile.include diff --git a/tests/driver_xbee/Makefile b/tests/driver_xbee/Makefile index 00c3ec8bf2..9db581403a 100644 --- a/tests/driver_xbee/Makefile +++ b/tests/driver_xbee/Makefile @@ -15,11 +15,6 @@ USEMODULE += shell_commands # No need of big buffer for this test CFLAGS += -DGNRC_PKTBUF_SIZE=512 -# Comment this out to disable code in RIOT that does safety checking -# which is not needed in a production environment but helps in the -# development process: -CFLAGS += -DDEVELHELP - # add current directory to the include path. Putting it in CFLAGS will make # it go to the beginning, before the standard includes. # That way xbee_params.h get's included and auto configuration can pick it up. diff --git a/tests/fault_handler/Makefile b/tests/fault_handler/Makefile index 6df6046605..e6344d86a9 100644 --- a/tests/fault_handler/Makefile +++ b/tests/fault_handler/Makefile @@ -1,8 +1,6 @@ # name of your application include ../Makefile.tests_common -CFLAGS += -DDEVELHELP=1 - ifeq ($(shell uname),Darwin) CFLAGS += -Wno-language-extension-token endif diff --git a/tests/gnrc_ipv6_ext/Makefile b/tests/gnrc_ipv6_ext/Makefile index 14f6c32b66..6ad7974e6e 100644 --- a/tests/gnrc_ipv6_ext/Makefile +++ b/tests/gnrc_ipv6_ext/Makefile @@ -22,11 +22,6 @@ USEMODULE += gnrc_udp # Add also the shell, some shell commands USEMODULE += ps -# Comment this out to disable code in RIOT that does safety checking -# which is not needed in a production environment but helps in the -# development process: -CFLAGS += -DDEVELHELP - include $(RIOTBASE)/Makefile.include # The test can check more things with ENABLE_DEBUG set to 1 in gnrc_ipv6.c diff --git a/tests/gnrc_ipv6_nib/Makefile b/tests/gnrc_ipv6_nib/Makefile index 6df9d4c6a9..fcf0e2048b 100644 --- a/tests/gnrc_ipv6_nib/Makefile +++ b/tests/gnrc_ipv6_nib/Makefile @@ -10,7 +10,6 @@ USEMODULE += embunit USEMODULE += netdev_eth USEMODULE += netdev_test -CFLAGS += -DDEVELHELP CFLAGS += -DGNRC_NETTYPE_NDP=GNRC_NETTYPE_TEST CFLAGS += -DGNRC_PKTBUF_SIZE=512 CFLAGS += -DTEST_SUITES diff --git a/tests/gnrc_ipv6_nib_6ln/Makefile b/tests/gnrc_ipv6_nib_6ln/Makefile index 51153f439a..d23e0b7a37 100644 --- a/tests/gnrc_ipv6_nib_6ln/Makefile +++ b/tests/gnrc_ipv6_nib_6ln/Makefile @@ -13,7 +13,6 @@ USEMODULE += embunit USEMODULE += netdev_ieee802154 USEMODULE += netdev_test -CFLAGS += -DDEVELHELP CFLAGS += -DGNRC_NETTYPE_NDP=GNRC_NETTYPE_TEST CFLAGS += -DGNRC_PKTBUF_SIZE=512 CFLAGS += -DTEST_SUITES diff --git a/tests/gnrc_netif/Makefile b/tests/gnrc_netif/Makefile index 70af7d5660..c56d9b4e3f 100644 --- a/tests/gnrc_netif/Makefile +++ b/tests/gnrc_netif/Makefile @@ -21,7 +21,6 @@ USEMODULE += netdev_ieee802154 USEMODULE += netdev_test USEMODULE += od -CFLAGS += -DDEVELHELP CFLAGS += -DGNRC_NETIF_NUMOF=4 CFLAGS += -DGNRC_NETIF_ADDRS_NUMOF=16 CFLAGS += -DGNRC_NETIF_GROUPS_NUMOF=8 diff --git a/tests/gnrc_sixlowpan/Makefile b/tests/gnrc_sixlowpan/Makefile index 0e799a31ae..43aeed4568 100644 --- a/tests/gnrc_sixlowpan/Makefile +++ b/tests/gnrc_sixlowpan/Makefile @@ -19,11 +19,6 @@ USEMODULE += gnrc_udp # Dumps packets USEMODULE += gnrc_pktdump -# Comment this out to disable code in RIOT that does safety checking -# which is not needed in a production environment but helps in the -# development process: -CFLAGS += -DDEVELHELP - include $(RIOTBASE)/Makefile.include test: diff --git a/tests/gnrc_sock_dns/Makefile b/tests/gnrc_sock_dns/Makefile index d0d1f06eb7..341393525b 100644 --- a/tests/gnrc_sock_dns/Makefile +++ b/tests/gnrc_sock_dns/Makefile @@ -16,8 +16,6 @@ USEMODULE += shell_commands USEMODULE += posix -CFLAGS += -DDEVELHELP - LOW_MEMORY_BOARDS := nucleo-f334 msb-430 msb-430h ifeq ($(BOARD),$(filter $(BOARD),$(LOW_MEMORY_BOARDS))) diff --git a/tests/gnrc_sock_ip/Makefile b/tests/gnrc_sock_ip/Makefile index 04cc21c2ef..bbc814ec6b 100644 --- a/tests/gnrc_sock_ip/Makefile +++ b/tests/gnrc_sock_ip/Makefile @@ -6,7 +6,6 @@ USEMODULE += gnrc_sock_ip USEMODULE += gnrc_ipv6 USEMODULE += ps -CFLAGS += -DDEVELHELP CFLAGS += -DGNRC_PKTBUF_SIZE=200 CFLAGS += -DTEST_SUITES diff --git a/tests/gnrc_sock_udp/Makefile b/tests/gnrc_sock_udp/Makefile index 6b581d2686..101f1ec862 100644 --- a/tests/gnrc_sock_udp/Makefile +++ b/tests/gnrc_sock_udp/Makefile @@ -7,7 +7,6 @@ USEMODULE += gnrc_sock_udp USEMODULE += gnrc_ipv6 USEMODULE += ps -CFLAGS += -DDEVELHELP CFLAGS += -DGNRC_PKTBUF_SIZE=400 CFLAGS += -DTEST_SUITES diff --git a/tests/gnrc_tcp_client/Makefile b/tests/gnrc_tcp_client/Makefile index 4cff867eac..aded1092bf 100644 --- a/tests/gnrc_tcp_client/Makefile +++ b/tests/gnrc_tcp_client/Makefile @@ -22,11 +22,6 @@ CFLAGS += -DTARGET_ADDR=\"$(TCP_TARGET_ADDR)\" CFLAGS += -DTARGET_PORT=$(TCP_TARGET_PORT) CFLAGS += -DCYCLES=$(TCP_TEST_CYCLES) -# Comment this out to disable code in RIOT that does safety checking -# which is not needed in a production environment but helps in the -# development process: -#CFLAGS += -DDEVELHELP - # Modules to include USEMODULE += gnrc_netdev_default USEMODULE += auto_init_gnrc_netif diff --git a/tests/gnrc_tcp_server/Makefile b/tests/gnrc_tcp_server/Makefile index 2cc9b8bc7c..5e1fb393e3 100644 --- a/tests/gnrc_tcp_server/Makefile +++ b/tests/gnrc_tcp_server/Makefile @@ -25,11 +25,6 @@ CFLAGS += -DLOCAL_ADDR=\"$(TCP_LOCAL_ADDR)\" CFLAGS += -DLOCAL_PORT=$(TCP_LOCAL_PORT) CFLAGS += -DCYCLES=$(TCP_TEST_CYCLES) -# Comment this out to disable code in RIOT that does safety checking -# which is not needed in a production environment but helps in the -# development process: -#CFLAGS += -DDEVELHELP - # Modules to include USEMODULE += gnrc_netdev_default USEMODULE += auto_init_gnrc_netif diff --git a/tests/gnrc_udp/Makefile b/tests/gnrc_udp/Makefile index b9b2711e33..6b8d4076df 100644 --- a/tests/gnrc_udp/Makefile +++ b/tests/gnrc_udp/Makefile @@ -20,8 +20,6 @@ USEMODULE += ps USEMODULE += netstats_l2 USEMODULE += netstats_ipv6 -CFLAGS += -DDEVELHELP - include $(RIOTBASE)/Makefile.include # Set a custom channel if needed diff --git a/tests/lwip_sock_ip/Makefile b/tests/lwip_sock_ip/Makefile index 65bb3064a8..351ad7cdd6 100644 --- a/tests/lwip_sock_ip/Makefile +++ b/tests/lwip_sock_ip/Makefile @@ -34,7 +34,6 @@ USEMODULE += ps DISABLE_MODULE += auto_init -CFLAGS += -DDEVELHELP CFLAGS += -DSO_REUSE CFLAGS += -DLWIP_SO_RCVTIMEO diff --git a/tests/lwip_sock_tcp/Makefile b/tests/lwip_sock_tcp/Makefile index 0422ca84a9..eb920b03b5 100644 --- a/tests/lwip_sock_tcp/Makefile +++ b/tests/lwip_sock_tcp/Makefile @@ -34,7 +34,6 @@ USEMODULE += ps DISABLE_MODULE += auto_init -CFLAGS += -DDEVELHELP CFLAGS += -DSO_REUSE CFLAGS += -DLWIP_SO_RCVTIMEO CFLAGS += -DLWIP_SOCK_TCP_ACCEPT_TIMEOUT=500 diff --git a/tests/lwip_sock_udp/Makefile b/tests/lwip_sock_udp/Makefile index afebcaa424..e22e13014c 100644 --- a/tests/lwip_sock_udp/Makefile +++ b/tests/lwip_sock_udp/Makefile @@ -34,7 +34,6 @@ USEMODULE += ps DISABLE_MODULE += auto_init -CFLAGS += -DDEVELHELP CFLAGS += -DSO_REUSE CFLAGS += -DLWIP_SO_RCVTIMEO diff --git a/tests/lwmac/Makefile b/tests/lwmac/Makefile index 7e2c4fed63..4235f85638 100644 --- a/tests/lwmac/Makefile +++ b/tests/lwmac/Makefile @@ -12,11 +12,6 @@ BOARD ?= samr21-xpro # be then accordingly extended. BOARD_WHITELIST := samr21-xpro -# Comment this out to disable code in RIOT that does safety checking -# which is not needed in a production environment but helps in the -# development process: -CFLAGS += -DDEVELHELP - # Modules to include: USEMODULE += shell USEMODULE += shell_commands diff --git a/tests/malloc/Makefile b/tests/malloc/Makefile index 4f0e81b7d8..24bb481657 100644 --- a/tests/malloc/Makefile +++ b/tests/malloc/Makefile @@ -1,8 +1,3 @@ include ../Makefile.tests_common -# Comment this out to disable code in RIOT that does safety checking -# which is not needed in a production environment but helps in the -# development process: -CFLAGS += -DDEVELHELP - include $(RIOTBASE)/Makefile.include diff --git a/tests/mpu_stack_guard/Makefile b/tests/mpu_stack_guard/Makefile index 3a8a6fdc14..c20367d18f 100644 --- a/tests/mpu_stack_guard/Makefile +++ b/tests/mpu_stack_guard/Makefile @@ -39,8 +39,6 @@ BOARD_WHITELIST += stm32f3discovery # cortex-m4f BOARD_WHITELIST += stm32f4discovery # cortex-m4f BOARD_WHITELIST += udoo # cortex-m3 -CFLAGS += -DDEVELHELP - USEMODULE += mpu_stack_guard include $(RIOTBASE)/Makefile.include diff --git a/tests/od/Makefile b/tests/od/Makefile index fbffa532e4..5703db0d12 100644 --- a/tests/od/Makefile +++ b/tests/od/Makefile @@ -3,11 +3,6 @@ include ../Makefile.tests_common USEMODULE += od # USEMODULE += od_string -# Comment this out to disable code in RIOT that does safety checking -# which is not needed in a production environment but helps in the -# development process: -CFLAGS += -DDEVELHELP - include $(RIOTBASE)/Makefile.include test: diff --git a/tests/openthread/Makefile b/tests/openthread/Makefile index f547007f75..6056a33365 100644 --- a/tests/openthread/Makefile +++ b/tests/openthread/Makefile @@ -8,11 +8,6 @@ BOARD_WHITELIST := samr21-xpro iotlab-m3 fox iotlab-a8-m3 # This has to be the absolute path to the RIOT base directory: RIOTBASE ?= $(CURDIR)/../.. -# Comment this out to disable code in RIOT that does safety checking -# which is not needed in a production environment but helps in the -# development process: -CFLAGS += -DDEVELHELP -Wall - # Change this to 0 show compiler invocation lines by default: QUIET ?= 1 diff --git a/tests/pkg_microcoap/Makefile b/tests/pkg_microcoap/Makefile index 26a2d5a667..aa020cb86d 100644 --- a/tests/pkg_microcoap/Makefile +++ b/tests/pkg_microcoap/Makefile @@ -22,11 +22,6 @@ USEPKG += microcoap # include this for printing IP addresses USEMODULE += shell_commands -# Comment this out to disable code in RIOT that does safety checking -# which is not needed in a production environment but helps in the -# development process: -#CFLAGS += -DDEVELHELP - # Use different settings when compiling for one of the following (low-memory) # boards LOW_MEMORY_BOARDS := nucleo-f334 diff --git a/tests/ps_schedstatistics/Makefile b/tests/ps_schedstatistics/Makefile index 09b7bbabe7..7ff522c769 100644 --- a/tests/ps_schedstatistics/Makefile +++ b/tests/ps_schedstatistics/Makefile @@ -5,7 +5,6 @@ BOARD_INSUFFICIENT_MEMORY := chronos msb-430 msb-430h nucleo-f030 nucleo-l053 \ stm32f0discovery telosb wsn430-v1_3b \ wsn430-v1_4 z1 -CFLAGS += -DDEVELHELP USEMODULE += shell USEMODULE += shell_commands USEMODULE += ps diff --git a/tests/sntp/Makefile b/tests/sntp/Makefile index ade6c309d9..9763168fdd 100644 --- a/tests/sntp/Makefile +++ b/tests/sntp/Makefile @@ -13,9 +13,4 @@ USEMODULE += gnrc_netdev_default USEMODULE += shell USEMODULE += shell_commands -# Comment this out to disable code in RIOT that does safety checking -# which is not needed in a production environment but helps in the -# development process: -CFLAGS += -DDEVELHELP - include $(RIOTBASE)/Makefile.include diff --git a/tests/ssp/Makefile b/tests/ssp/Makefile index 845020e4a5..842461b75d 100644 --- a/tests/ssp/Makefile +++ b/tests/ssp/Makefile @@ -7,9 +7,6 @@ BOARD_BLACKLIST := arduino-mega2560 waspmote-pro arduino-uno arduino-duemilanove USEMODULE += ssp -# set DEVELHELP so the board halts after crash -CFLAGS += -DDEVELHELP - include $(RIOTBASE)/Makefile.include test: