RIOT-OS/RIOT
RIOT-OS/RIOT
1
0
Fork 0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2025-01-17 17:52:47 +01:00
Code Releases Activity

drivers/bmx055: eliminate some casts

Browse Source 
First, every read function converts the void pointer into a const bmx055_t

Second, it is cleaner (more obvious) to pass phydat_t.val[3] instead of
type casting to int16_t* and relying that .val[3] is the first struct
member of phydat_t.
This commit is contained in:
Kees Bakker 2019-01-05 15:37:02 +01:00
parent a1218f007b
commit 52102a7aa0
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/bmx055/bmx055_saul.c
View File

@ -24,7 +24,9 @@
static int read_mag(const void *dev, phydat_t *res) static int read_mag(const void *dev, phydat_t *res)
{ {
if (bmx055_mag_read((bmx055_t *)dev, (int16_t *)res) != BMX055_OK) { const bmx055_t *mydev = (const bmx055_t *)dev;
if (bmx055_mag_read(mydev, res->val) != BMX055_OK) {
return 0; return 0;
} }
res->unit = UNIT_GS; res->unit = UNIT_GS;
@ -34,7 +36,9 @@ static int read_mag(const void *dev, phydat_t *res)
static int read_acc(const void *dev, phydat_t *res) static int read_acc(const void *dev, phydat_t *res)
{ {
if (bmx055_acc_read((bmx055_t *)dev, (int16_t *)res) != BMX055_OK) { const bmx055_t *mydev = (const bmx055_t *)dev;
if (bmx055_acc_read(mydev, res->val) != BMX055_OK) {
return 0; return 0;
} }
res->unit = UNIT_G; res->unit = UNIT_G;
@ -44,7 +48,9 @@ static int read_acc(const void *dev, phydat_t *res)
static int read_gyro(const void *dev, phydat_t *res) static int read_gyro(const void *dev, phydat_t *res)
{ {
if (bmx055_gyro_read((bmx055_t *)dev, (int16_t *)res) != BMX055_OK) { const bmx055_t *mydev = (const bmx055_t *)dev;
if (bmx055_gyro_read(mydev, res->val) != BMX055_OK) {
return 0; return 0;
} }
res->unit = UNIT_DPS; res->unit = UNIT_DPS;