RIOT-OS/RIOT
RIOT-OS/RIOT
1
0
Fork 0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2024-12-29 04:50:03 +01:00
Code Releases Activity

cpu/msp430/periph_timer: add a static_assert() for clear mask

Browse Source 
The driver assumes that timer A and timer B have the same register
layout regarding all the features exposed by the driver. This is
backed by the MCU family datasheets for the MSP430 x1xx and the
MSP430 G2xx / F2xx MCUs (and likely more families).

The assert() is pretty limited in coverage, but more to document why
a "timer A clear" mask is used but still claiming the driver also
works for timer B. It just looks too much like a bug otherwise.
This commit is contained in:
Marian Buschsieweke 2024-04-14 14:07:50 +02:00
parent 3cdc4379b7
commit 49d59d166d
No known key found for this signature in database
GPG Key ID: 77AA882EC78084E6
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
cpu/msp430/periph/timer.c
View File

@ -97,7 +97,12 @@ int timer_init(tim_t dev, uint32_t freq, timer_cb_t cb, void *arg)
assume((unsigned)dev < TIMER_NUMOF);
msp430_timer_t *msptimer = timer_conf[dev].timer;
/* reset the timer A configuration */
static_assert(TACLR == TBCLR, "This driver assumes TIMER A and TIMER B "
"having the same register layout for the "
"features exposed by this driver. This "
"is backed by the datasheet for both "
"MSP430 x1xx and G2xx / F2xx MCUs.");
/* reset the timer configuration */
msptimer->CTL = TACLR;
/* save callback */
isr_ctx[dev].cb = cb;