RIOT-OS/RIOT
RIOT-OS/RIOT
1
0
Fork 0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2024-12-29 04:50:03 +01:00
Code Releases Activity

sys/arduino: Bug and style fixes in SPI

Browse Source 
- set is_transaction before releasing the SPI bus (and the mutex) to avoid
  data races
- adapt switch indent to coding convention
This commit is contained in:
Marian Buschsieweke 2021-02-02 08:35:52 +01:00
parent dd0c13d227
commit 45ed8bc330
No known key found for this signature in database
GPG Key ID: 61F64C6599B1539F
1 changed files with 27 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
sys/arduino/SPI.cpp
View File

@ -39,19 +39,19 @@ SPISettings::SPISettings(uint32_t clock_hz, uint8_t bitOrder, uint8_t dataMode)
assert(bitOrder == MSBFIRST);
switch(dataMode) {
default:
case SPI_MODE0:
mode = SPI_MODE_0;
break;
case SPI_MODE1:
mode = SPI_MODE_1;
break;
case SPI_MODE2:
mode = SPI_MODE_2;
break;
case SPI_MODE3:
mode = SPI_MODE_3;
break;
default:
case SPI_MODE0:
mode = SPI_MODE_0;
break;
case SPI_MODE1:
mode = SPI_MODE_1;
break;
case SPI_MODE2:
mode = SPI_MODE_2;
break;
case SPI_MODE3:
mode = SPI_MODE_3;
break;
}
for (uint8_t i = 0; i < ARRAY_SIZE(steps); i++) {
@ -90,8 +90,8 @@ void SPIClass::beginTransaction(SPISettings settings)
void SPIClass::endTransaction()
{
spi_release(spi_dev);
is_transaction = false;
spi_release(spi_dev);
rmutex_unlock(&mut);
}
@ -125,19 +125,19 @@ void SPIClass::setBitOrder(uint8_t order)
void SPIClass::setDataMode(uint8_t dataMode)
{
switch(dataMode) {
default:
case SPI_MODE0:
settings.mode = SPI_MODE_0;
break;
case SPI_MODE1:
settings.mode = SPI_MODE_1;
break;
case SPI_MODE2:
settings.mode = SPI_MODE_2;
break;
case SPI_MODE3:
settings.mode = SPI_MODE_3;
break;
default:
case SPI_MODE0:
settings.mode = SPI_MODE_0;
break;
case SPI_MODE1:
settings.mode = SPI_MODE_1;
break;
case SPI_MODE2:
settings.mode = SPI_MODE_2;
break;
case SPI_MODE3:
settings.mode = SPI_MODE_3;
break;
}
}