RIOT-OS/RIOT
RIOT-OS/RIOT
1
0
Fork 0
mirror of https://github.com/RIOT-OS/RIOT.git synced 2024-12-29 04:50:03 +01:00
Code Releases Activity

Merge #19522

Browse Source 
19522: tests/periph_rtt: Fix for tick conversion test  r=benpicco a=chudov

### Contribution description

Type casting and `printf` formatting for the `RTT_MAX_VALUE` and `RTT_FREQUENCY` are fixed so 32-bit value is properly handled by  'avr-libc'.
The original tick conversion test assumes that `RTT_FREQUENCY` is power of 2 so forward and backward ticks to seconds conversion results in the original ticks value. To fix it the result of the forward-backward conversion is compared with `ticktest / RTT_FREQUENCY * RTT_FREQUENCY` that considers rounding errors.

Changes were tested on deRFmega256 and nrf52840dongle.

### Testing procedure

tests/periph_rtt on a board with ATmega256RFR2 shall:
* show correct RTT_MAX_VALUE 
* conversion check shall report no error.

### Issues/PRs references

Fixes #15940 


Co-authored-by: chudov <chudov@gmail.com>
This commit is contained in:
bors[bot] 2023-05-04 23:10:52 +00:00 committed by GitHub
commit 34c094d15d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tests/periph_rtt/main.c
View File

@ -92,7 +92,6 @@ static void _get_rtc_mem(void)
}
}
puts("RTC mem OK");
}
#else
@ -105,17 +104,17 @@ int main(void)
puts("\nRIOT RTT low-level driver test");
puts("RTT configuration:");
printf("RTT_MAX_VALUE: 0x%08x\n", (unsigned)RTT_MAX_VALUE);
printf("RTT_FREQUENCY: %u\n\n", (unsigned)RTT_FREQUENCY);
printf("RTT_MAX_VALUE: 0x%08" PRIx32 "\n", (uint32_t)RTT_MAX_VALUE);
printf("RTT_FREQUENCY: %" PRIu32 "\n\n", (uint32_t)RTT_FREQUENCY);
puts("Testing the tick conversion");
for (unsigned i = 0; i < ARRAY_SIZE(_ticktest); i++) {
puts("Testing the tick conversion (with rounding if RTT_FREQUENCY is not power of 2)");
for (uint16_t i = 0; i < ARRAY_SIZE(_ticktest); i++) {
uint32_t sec = RTT_TICKS_TO_SEC(_ticktest[i]);
uint32_t ticks = RTT_SEC_TO_TICKS(sec);
printf("Trying to convert %" PRIu32 " to seconds and back\n",
_ticktest[i]);
/* account for rounding errors... */
if ((ticks != 0) && (ticks != _ticktest[i])) {
/* RTT_FREQUENCY is not always power of 2 so compare with rounded result */
if ((ticks != 0) && (ticks != _ticktest[i] / RTT_FREQUENCY * RTT_FREQUENCY)) {
puts("error: TICK conversion not working as expected\n");
return 1;
}