From 195d6617b2d239973a8f8091f764c38b4f321b6c Mon Sep 17 00:00:00 2001 From: Marian Buschsieweke Date: Tue, 28 May 2024 20:52:53 +0200 Subject: [PATCH] dist/tools/buildsystem_sanity_check: Relax on Makefile.features In order to extend features based on provided features, we need to check contents of `FEATURES_PROVIDED`. --- dist/tools/buildsystem_sanity_check/check.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/dist/tools/buildsystem_sanity_check/check.sh b/dist/tools/buildsystem_sanity_check/check.sh index 9ee0eb0eee..777caa12a5 100755 --- a/dist/tools/buildsystem_sanity_check/check.sh +++ b/dist/tools/buildsystem_sanity_check/check.sh @@ -74,6 +74,12 @@ check_not_parsing_features() { # These two files contain sanity checks using FEATURES_ so are allowed pathspec+=(':!Makefile.include' ':!makefiles/info-global.inc.mk') + # We extend features provided in Makefile.features based on what is + # already provided to avoid clutter in each boards Makefile.features. + # E.g. `periph_eth` will pull in `netif_ethernet`, which + # will pull in `netif`. + pathspec+=(':!Makefile.features') + git -C "${RIOTBASE}" grep -n "${patterns[@]}" -- "${pathspec[@]}" \ | error_with_message 'Modules should not check the content of FEATURES_PROVIDED/REQUIRED/OPTIONAL' }