From 13d080d15cf7b1ef2eed75790b46744a7aa1bb88 Mon Sep 17 00:00:00 2001 From: Gunar Schorcht Date: Mon, 3 Jul 2023 14:19:07 +0200 Subject: [PATCH] boards/esp32s3-devkit: fix documentation --- boards/esp32s3-devkit/doc.txt | 2 ++ boards/esp32s3-devkit/include/board.h | 16 +++++++++------- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/boards/esp32s3-devkit/doc.txt b/boards/esp32s3-devkit/doc.txt index edbf6e4166..bbcc9db6bd 100644 --- a/boards/esp32s3-devkit/doc.txt +++ b/boards/esp32s3-devkit/doc.txt @@ -167,6 +167,8 @@ UART_DEV(0) RxD | GPIO44 | Console (configuration is fixed) | \ref esp32_uart_in \n +@note The RGB-LED is connected to GPIO38 on ESP32-S3-DevKitC-1 revision 1.1 boards. + For detailed information about the peripheral configurations of ESP32-S3 boards, see section \ref esp32_peripherals "Common Peripherals". diff --git a/boards/esp32s3-devkit/include/board.h b/boards/esp32s3-devkit/include/board.h index ecf22ec4a6..7bb2768f12 100644 --- a/boards/esp32s3-devkit/include/board.h +++ b/boards/esp32s3-devkit/include/board.h @@ -42,8 +42,8 @@ /** * @brief Default button GPIO pin definition * - * ESP32-S3-DevKit boards have a BOOT button connected to GPIO9, which can be - * used as button during normal operation. Since the GPIO9 pin is pulled up, + * ESP32-S3-DevKit boards have a BOOT button connected to GPIO0, which can be + * used as button during normal operation. Since the GPIO0 pin is pulled up, * the button signal is inverted, i.e., pressing the button will give a * low signal. */ @@ -51,9 +51,6 @@ /** * @brief Default button GPIO mode definition - * - * Since the GPIO of the button is pulled up with an external resistor, the - * mode for the GPIO pin has to be GPIO_IN. */ #define BTN0_MODE GPIO_IN_PU @@ -74,8 +71,13 @@ /** * @name LED (on-board) configuration * - * ESP32-S3-DevKit boards have a SK68XXMINI-HS smart RGB-LED connected to - * GPIO48 on-board. The WS281x driver module `ws281x` can be used to control it. + * ESP32-S3-DevKit boards have a SK68XXMINI-HS smart RGB LED on-board connected + * to either + * + * - GPIO48 (ESP32-S3-DevKitC-1 revision 1.0 and all ESP32-S3-DevKitM-1 boards) or + * - GPIO38 (ESP32-S3-DevKitC-1 revision 1.1). + * + * The WS281x driver module `ws281x` can be used for control. * @{ */ #ifndef WS281X_PARAM_PIN